Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-cdk/aws-dynamodb): Create table replica in background #16611

Closed
1 of 2 tasks
TheSPD opened this issue Sep 22, 2021 · 1 comment · Fixed by #16983
Closed
1 of 2 tasks

(aws-cdk/aws-dynamodb): Create table replica in background #16611

TheSPD opened this issue Sep 22, 2021 · 1 comment · Fixed by #16983
Assignees
@skinny85
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/medium Medium work item – several days of effort feature/pfr Product Feature Requests that originated outside of GitHub feature-request A feature should be added or improved. p1

Comments

@TheSPD
Copy link
Contributor

TheSPD commented Sep 22, 2021 •
edited
Loading

Requesting another property under TableOptions to create the Table replica in background without checks.

Use Case

When creating DynamoDB Table Replica, the replica generation might take more than 1 hour sometimes due to big table sizes. Cloudformation does not have patience to wait for that long and kills the deployment even when replicationTimeout property on the Table API is set to a higher number (say 6 hours).

In our case, it takes 3.5 hours for the replica to be created.

Proposed Solution

The property can then be used in the lambda
to send appropriate isComplete response back to CloudFormation and let it continue without actually checking if replication has completed.

Other

None

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@TheSPD TheSPD added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 22, 2021
@github-actions github-actions bot added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label Sep 22, 2021
@skinny85 skinny85 added effort/medium Medium work item – several days of effort feature/pfr Product Feature Requests that originated outside of GitHub p1 and removed needs-triage This issue or PR still needs to be triaged. labels Sep 22, 2021
@skinny85 skinny85 removed their assignment Sep 22, 2021
@TheSPD TheSPD mentioned this issue Oct 14, 2021
Merged
@mergify mergify bot closed this as completed in #16983 Oct 15, 2021
mergify bot pushed a commit that referenced this issue Oct 15, 2021
@TheSPD
feat(dynamodb): add option to skip waiting for global replication to …
254601f 
…finish (#16983)

Motivation - On large tables, replication takes long time to complete. CloudFormation has a hard timeout of 1 hour on the Custom Resources, to bypass this, we want to have the replication continue in background based on a property.

Fixes #16611 


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@TheSPD @TikiTDO
feat(dynamodb): add option to skip waiting for global replication to …
64a7bc3 
…finish (aws#16983)

Motivation - On large tables, replication takes long time to complete. CloudFormation has a hard timeout of 1 hour on the Custom Resources, to bypass this, we want to have the replication continue in background based on a property.

Fixes aws#16611 


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/medium Medium work item – several days of effort feature/pfr Product Feature Requests that originated outside of GitHub feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dynamodb): add option to skip waiting for global replication to finish TheSPD/aws-cdk
2 participants
@skinny85 @TheSPD