Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(@aws-cdk/aws-kinesisanalytics-flink): Add support to Apache Flink v1.13 #16985

Closed
1 of 2 tasks
mattiamatrix opened this issue Oct 14, 2021 · 5 comments · Fixed by #17019
Closed
1 of 2 tasks

(@aws-cdk/aws-kinesisanalytics-flink): Add support to Apache Flink v1.13 #16985

mattiamatrix opened this issue Oct 14, 2021 · 5 comments · Fixed by #17019
Assignees
Labels
@aws-cdk/aws-kinesis Related to Amazon Kinesis effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@mattiamatrix
Copy link
Contributor

mattiamatrix commented Oct 14, 2021

Description

Amazon Kinesis Data Analytics now supports Apache Flink v1.13 (LINK).

Please add support to Apache Flink v1.13 to the L2 construct for Kinesis Analytics Flink applications.

Use Case

Use Apache Flink v1.13 Kinesis Analytics Flink applications deployed with CDK.

Proposed Solution

Add static variable FLINK_1_13 in class @aws-cdk_aws-kinesisanalytics-flink.Runtime.

Other information

#17019

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@mattiamatrix mattiamatrix added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 14, 2021
@github-actions github-actions bot added the @aws-cdk/aws-kinesis Related to Amazon Kinesis label Oct 14, 2021
@otaviomacedo
Copy link
Contributor

Hi, @mattiamatrix. If you can submit a PR for this, I'd be happy to review it.

@otaviomacedo otaviomacedo added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Oct 15, 2021
@mattiamatrix
Copy link
Contributor Author

mattiamatrix commented Oct 15, 2021

@jumic
Copy link
Contributor

jumic commented Oct 17, 2021

Did you try to deploy version 1.13? I could deploy it successfully in region us-east-1 using this code snippet:

new flink.Application(this, 'App', {
  code: flink.ApplicationCode.fromAsset(path.join(__dirname, 'code-asset')),
  runtime: flink.Runtime.of('FLINK-1_13'),
});

Probably the CloudFormation documentation is not up to date yet. Maybe you can wait a few days to see if AWS updates the documentation automatically. If not, you can try to add the version by creating a pull request for the documentation. There is a link named "Edit this page on GitHub" at the bottom of the CloudFormation documentation.

If you can also deploy the new version, I would suggest that you proceed with your pull request.

@mattiamatrix
Copy link
Contributor Author

True, thanks @jumic, it works also in eu-west-2.

@otaviomacedo, #17019 can be reviewed.

@mergify mergify bot closed this as completed in #17019 Oct 22, 2021
mergify bot pushed a commit that referenced this issue Oct 22, 2021
Add support to Flink 1.13 in construct `@aws-cdk/aws-kinesisanalytics-flink » Application`

This fixes #16985

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
Add support to Flink 1.13 in construct `@aws-cdk/aws-kinesisanalytics-flink » Application`

This fixes aws#16985

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-kinesis Related to Amazon Kinesis effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants