Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cloud9): Add support for SSM connection type #17027

Closed
1 of 2 tasks
otterley opened this issue Oct 17, 2021 · 2 comments · Fixed by #20250
Closed
1 of 2 tasks

(cloud9): Add support for SSM connection type #17027

otterley opened this issue Oct 17, 2021 · 2 comments · Fixed by #20250
Labels
@aws-cdk/aws-cloud9 Related to AWS Cloud9 effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. p2

Comments

@otterley
Copy link
Contributor

Description

Add support for SSM connection type as per https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloud9-environmentec2.html#cfn-cloud9-environmentec2-connectiontype

Use Case

This will make it easier for customers to install their Cloud9 environments into private subnets while still allowing access to the IDE via the console.

Proposed Solution

Add a new property for the connection type. The property can be an enumerated type whose valid values can be either SSH or SSM. It might also be helpful to default to SSM automatically if the provided subnet types are private.

Other information

Workaround:

cloud9env.node.defaultChild as cloud9.CfnEnvironmentEC2).connectionType = 'CONNECT_SSM';

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@otterley otterley added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 17, 2021
@github-actions github-actions bot added the @aws-cdk/aws-cloud9 Related to AWS Cloud9 label Oct 17, 2021
@skinny85
Copy link
Contributor

Thanks for opening the issue @otterley! We encourage community contributions, so if you'd like to open us a Pull Request adding this feature, that would be fantastic! Our "Contributing" guide: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md.

Thanks,
Adam

@skinny85 skinny85 added effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs p2 and removed needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2021
@skinny85 skinny85 removed their assignment Oct 18, 2021
@daschaa daschaa mentioned this issue May 7, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #20250 May 19, 2022
mergify bot pushed a commit that referenced this issue May 19, 2022
@daschaa
feat(cloud9): configure Connection Type of Ec2Environment (#20250)
01708bc 
Fixes #17027. Adds `connectionType` property to the L2 Construct `cloud9.Ec2Environment`. For the  connection type an enum was implemented which is either `"CONNECT_SSH` or `CONNECT_SSM`.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

wphilipw pushed a commit to wphilipw/aws-cdk that referenced this issue May 23, 2022
@daschaa @wphilipw
feat(cloud9): configure Connection Type of Ec2Environment (aws#20250)
38bc651 
Fixes aws#17027. Adds `connectionType` property to the L2 Construct `cloud9.Ec2Environment`. For the  connection type an enum was implemented which is either `"CONNECT_SSH` or `CONNECT_SSM`.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cloud9 Related to AWS Cloud9 effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloud9): configure Connection Type of Ec2Environment daschaa/aws-cdk
2 participants
@otterley @skinny85