Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-ec2): Extend BastionHostLinux to support CloudFormationInit #17161

Closed
1 of 2 tasks
mpvosseller opened this issue Oct 26, 2021 · 4 comments
Closed
1 of 2 tasks

(aws-ec2): Extend BastionHostLinux to support CloudFormationInit #17161

mpvosseller opened this issue Oct 26, 2021 · 4 comments
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@mpvosseller
Copy link
Contributor

mpvosseller commented Oct 26, 2021

Description

It would be helpful if the BastionHostLinux constructor accepted optional CloudFormationInit and ApplyCloudFormationInitOptions arguments to be passed to the ​underlying Instance. This would enable full CloudFormation ​initialization of the instance like installing files.

/**
    ​* Apply the given CloudFormation Init configuration to the instance at startup.
    ​*
    ​* @default - no CloudFormation init
    ​* @stability stable
    ​*/
   ​readonly init?: CloudFormationInit;/**
    ​* Use the given options for applying CloudFormation Init.
    ​*
    ​* Describes the configsets to use and the timeout to wait
    ​*
    ​* @default - default options
    ​* @stability stable
    ​*/
   ​readonly initOptions?: ApplyCloudFormationInitOptions;

Use Case

In my case I want to install files and run a command at initialization time.

Proposed Solution

Add two optional arguments init and initOptions to BastionHostLinuxProps. In BastionHostLinux pass these arguments to the Instance constructor when creating the underlying instance.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@mpvosseller mpvosseller added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 26, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Oct 26, 2021
@njlynch njlynch added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 15, 2021
@njlynch
Copy link
Contributor

njlynch commented Nov 15, 2021

Sure, that seems like a reasonable request. We welcome community contributions!

@jkuek
Copy link

jkuek commented Nov 19, 2021

Thanks, looking forward to this change!

mpvosseller added a commit to mpvosseller/aws-cdk that referenced this issue Nov 19, 2021
mpvosseller added a commit to mpvosseller/aws-cdk that referenced this issue Nov 20, 2021
mpvosseller added a commit to mpvosseller/aws-cdk that referenced this issue Nov 22, 2021
mpvosseller added a commit to mpvosseller/aws-cdk that referenced this issue Nov 26, 2021
mpvosseller added a commit to mpvosseller/aws-cdk that referenced this issue Nov 27, 2021
mpvosseller added a commit to mpvosseller/aws-cdk that referenced this issue Nov 29, 2021
mpvosseller added a commit to mpvosseller/aws-cdk that referenced this issue Nov 29, 2021
mpvosseller added a commit to mpvosseller/aws-cdk that referenced this issue Nov 29, 2021
mpvosseller added a commit to mpvosseller/aws-cdk that referenced this issue Nov 29, 2021
mpvosseller added a commit to mpvosseller/aws-cdk that referenced this issue Nov 30, 2021
mergify bot pushed a commit that referenced this issue Nov 30, 2021
)

Implements #17161

Extends the `BastionHostLinux` constructor to accept optional `CloudFormationInit` and `ApplyCloudFormationInitOptions` arguments to be passed to the underlying instance.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
pedrosola pushed a commit to pedrosola/aws-cdk that referenced this issue Dec 1, 2021
…#17507)

Implements aws#17161

Extends the `BastionHostLinux` constructor to accept optional `CloudFormationInit` and `ApplyCloudFormationInitOptions` arguments to be passed to the underlying instance.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@cmazuc
Copy link

cmazuc commented Jan 20, 2022

Appreciate the work on this so far, are there plans to support cfn-hup?

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-hup.html

Right now the generated UserData doesn't configure cfn-hup so any updates to the AWS::CloudFormation::Init resource aren't picked up without a host replacement.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
…#17507)

Implements aws#17161

Extends the `BastionHostLinux` constructor to accept optional `CloudFormationInit` and `ApplyCloudFormationInitOptions` arguments to be passed to the underlying instance.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jan 20, 2023
@github-actions github-actions bot added closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

No branches or pull requests

4 participants