Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-applicationautoscaling): Typo in PredefinedMetric enum #17209

Closed
ivanmarquescepsa opened this issue Oct 28, 2021 · 3 comments · Fixed by #18085
Closed

(aws-applicationautoscaling): Typo in PredefinedMetric enum #17209

ivanmarquescepsa opened this issue Oct 28, 2021 · 3 comments · Fixed by #18085
Assignees
@comcalvi
Labels
@aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p1

Comments

@ivanmarquescepsa
Copy link

ivanmarquescepsa commented Oct 28, 2021 •
edited by NGL321
Loading

What is the problem?

DynamoDBWriteCapacityUtilization value in PredefinedMetric enum is defined as DYANMODB_WRITE_CAPACITY_UTILIZATION and it should be DYNAMODB_WRITE_CAPACITY_UTILIZATION

Reproduction Steps

Create any TargetTrackingScalingPolicy with predefined metric DynamoDBWriteCapacityUtilization

What did you expect to happen?

The enum property should be DYNAMODB_WRITE_CAPACITY_UTILIZATION

What actually happened?

The enum property is DYANMODB_WRITE_CAPACITY_UTILIZATION

CDK CLI Version

2.0.0-rc.26

Framework Version

2.0.0-rc26

Node.js Version

v16.13.0

OS

MacOS 11.6

Language

Python

Language Version

3.8.9

Other information

No response
@ivanmarquescepsa ivanmarquescepsa added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 28, 2021
@github-actions github-actions bot added the @aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling label Oct 28, 2021
@NGL321 NGL321 added the p1 label Oct 29, 2021
@NGL321
Copy link
Contributor

NGL321 commented Oct 29, 2021

Hey @keepler-ivanmarques,

I am not sure I am understanding correctly the issue here. The value seems to match the guidance of the related article. Could you specify what you think is wrong? (You listed the expected value as the same as the given value)

@NGL321 NGL321 added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Oct 29, 2021
@ivanmarquescepsa
Copy link
Author

Hi.

Sorry, it's not the same value

DYANMODB_WRITE_CAPACITY_UTILIZATION is not the same as DYNAMODB_WRITE_CAPACITY_UTILIZATION

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Oct 31, 2021
@jumic jumic mentioned this issue Dec 18, 2021
Merged
@mergify mergify bot closed this as completed in #18085 Jan 14, 2022
mergify bot pushed a commit that referenced this issue Jan 14, 2022
@jumic
fix(applicationautoscaling): typo in `DYANMODB_WRITE_CAPACITY_UTILIZA…
626e6aa 
…TION` (#18085)

Enum value `DYANMODB_WRITE_CAPACITY_UTILIZATION` in `PredefinedMetric` has a typo in `DYANMODB`.
This PR deprecates this value and adds the new value `DYNAMODB_WRITE_CAPACITY_UTILIZATION`.

I think we don't need to add a test case to this PR. Please add the label `pr-linter/exempt-test` if you agree.

Fixes #17209.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@jumic @TikiTDO
fix(applicationautoscaling): typo in `DYANMODB_WRITE_CAPACITY_UTILIZA…
9b05065 
…TION` (aws#18085)

Enum value `DYANMODB_WRITE_CAPACITY_UTILIZATION` in `PredefinedMetric` has a typo in `DYANMODB`.
This PR deprecates this value and adds the new value `DYNAMODB_WRITE_CAPACITY_UTILIZATION`.

I think we don't need to add a test case to this PR. Please add the label `pr-linter/exempt-test` if you agree.

Fixes aws#17209.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comcalvi comcalvi

Labels
@aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(applicationautoscaling): typo in DYANMODB_WRITE_CAPACITY_UTILIZATION jumic/aws-cdk
3 participants
@NGL321 @ivanmarquescepsa @comcalvi