Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing AWS Construct Library for AWS::Logs resources #174

Closed
eladb opened this issue Jun 25, 2018 · 2 comments
Closed

Missing AWS Construct Library for AWS::Logs resources #174

eladb opened this issue Jun 25, 2018 · 2 comments

Comments

@eladb
Copy link
Contributor

eladb commented Jun 25, 2018

AWS::Logs includes:

@eladb
Copy link
Contributor Author

eladb commented Jun 25, 2018

As a workaround, one can use the generated resources for CloudWatch Logs in @aws-cdk/resources:

import { logs } from '@aws-cdk/resources'

new logs.LogGroupResource(this, 'MyLogGroup,' { /* ... */ });

@rix0rrr
Copy link
Contributor

rix0rrr commented Jul 9, 2018

Notes about future design:

  • We should probably set a default retention period (1 or 2 years), infinite retention should be opt-in (imho). The usual case will be retaining logs over a well-defined period of time (for compliance reasons) and also we don't want to encourage customer to accumulate ever-increasing charges.
  • We should probably set all LogGroups to DeletionPolicy::Retain (unless overridden). If log groups and the associated resources are replaced in the course of a regular deployment (looking at you, Lamda), we don't want to delete all logs. Our normal retention period will take care of eventually aging out the log data, so again we're not accumulating endlessly.

rix0rrr pushed a commit that referenced this issue Jul 12, 2018
- Rename SubscriptionDestionation->LogSubscriptionDestination.
- Introducing Arn.parseToken()
- Use FnConcat instead of FnSub to build a region-aware service principal
- Add an additional safeguard in the cross-account subscription generation
  for if one account is unset.

Don't forget to mention this fixes #174.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants