Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-applicationautoscaling): Support datapointsToAlarm in StepScalingPolicy #17433

Closed
1 of 2 tasks
stephenwiebe opened this issue Nov 9, 2021 · 1 comment · Fixed by #17441
Closed
1 of 2 tasks

(aws-applicationautoscaling): Support datapointsToAlarm in StepScalingPolicy #17433

stephenwiebe opened this issue Nov 9, 2021 · 1 comment · Fixed by #17441
Assignees
@comcalvi
Labels
@aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@stephenwiebe
Copy link
Contributor

Description

StepScalingPolicy currently supports setting evaluationPeriods for the upper and lower autoscaling alarms, but not datapointsToAlarm. This means that to trigger the alarm, all data points in the evaluation period must trigger.

Use Case

I would like to create an autoscaling alarm that triggers when only a portion of the datapoints in the evaluation period have triggered.

Proposed Solution

Add an optional property to StepScalingPolicy for datapointsToAlarm that is passed to the underlying Alarm.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@stephenwiebe stephenwiebe added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 9, 2021
@github-actions github-actions bot added the @aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling label Nov 9, 2021
@ryparker ryparker added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 9, 2021
@stephenwiebe stephenwiebe mentioned this issue Nov 9, 2021
Merged
@mergify mergify bot closed this as completed in #17441 Dec 14, 2021
mergify bot pushed a commit that referenced this issue Dec 14, 2021
@stephenwiebe
feat(aws-applicationautoscaling): Allow autoscaling with "M out of N"…
c21320d 
… datapoints (#17441)

This PR closes #17433. It adds a `datapointsToAlarm` property to the `StepScalingPolicy` construct which allows auto-scaling activities to trigger when only a portion of the data points in the evaluation periods are breaching.

Motivation: Some metrics may have a certain amount of noise/randomness and in these cases it may make more sense to not require that all data points must be breaching for auto-scaling activity to trigger.
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@stephenwiebe @TikiTDO
feat(aws-applicationautoscaling): Allow autoscaling with "M out of N"…
0b61316 
… datapoints (aws#17441)

This PR closes aws#17433. It adds a `datapointsToAlarm` property to the `StepScalingPolicy` construct which allows auto-scaling activities to trigger when only a portion of the data points in the evaluation periods are breaching.

Motivation: Some metrics may have a certain amount of noise/randomness and in these cases it may make more sense to not require that all data points must be breaching for auto-scaling activity to trigger.
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comcalvi comcalvi

Labels
@aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
3 participants
@stephenwiebe @ryparker @comcalvi