(docdb): It should be possible to change the secretName for the created secret

[markussiebert]

Description

At the moment, a secret will be created for the docdb if only the username is specified. This is fine, but it would be nice, if it's possible to change the secretname.

Use Case

We grant our projects IAM permissions to read/write secrets on paths on secretsmanager. The autogenerated names don't match on the paths we allow them to access.

Proposed Solution

Add a property

export interface Login {
  /**
   * The name of the secret that will be created
   * @default undefined
   */
   readonly secretName?: string;
   ...

and change this accordingly

 // Create the secret manager secret if no password is specified
    let secret: DatabaseSecret | undefined;
    if (!props.masterUser.password) {
      secret = new DatabaseSecret(this, 'Secret', {
        username: props.masterUser.username,
        encryptionKey: props.masterUser.kmsKey,
        excludeCharacters: props.masterUser.excludeCharacters,
        secretName: props.masterUser.secretName, //added 
      });
    }

Other information

that's it

Acknowledge

• I may be able to implement this feature request
• This feature might incur a breaking change

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.