Refactor the CLI #176
Labels
feature-request
A feature should be added or improved.
Comments
RomainMuller
added a commit
that referenced
this issue
Jun 25, 2018
Breaking down the monolithic CLI infrastructure by using `yarg`'s `commandDir` directive (see #176). This allows modelling each command in a separate module for a cleaner interface. Migrated the `docs` command, and created a prototype of a `doctor` command (see #154). The new commands also have basic unit tests that verify the handlers honor their promises.
RomainMuller
added a commit
that referenced
this issue
Jun 25, 2018
Breaking down the monolithic CLI infrastructure by using `yarg`'s `commandDir` directive (see #176). This allows modelling each command in a separate module for a cleaner interface. Migrated the `docs` command, and created a prototype of a `doctor` command (see #154). The new commands also have basic unit tests that verify the handlers honor their promises.
RomainMuller
added a commit
that referenced
this issue
Jun 25, 2018
Breaking down the monolithic CLI infrastructure by using `yarg`'s `commandDir` directive (see #176). This allows modelling each command in a separate module for a cleaner interface. Migrated the `docs` command, and created a prototype of a `doctor` command (see #154). The new commands also have basic unit tests that verify the handlers honor their promises.
RomainMuller
added a commit
that referenced
this issue
Jun 25, 2018
Breaking down the monolithic CLI infrastructure by using `yarg`'s `commandDir` directive (see #176). This allows modelling each command in a separate module for a cleaner interface. Migrated the `docs` command, and created a prototype of a `doctor` command (see #154). The new commands also have basic unit tests that verify the handlers honor their promises.
|
Something that came up that we should consider is: does it make sense to rewrite the CDK CLI into the AWS CLI? |
|
It might make sense in the future, yes. That is a direction we are definitely looking forward to, possibly at some point next year. |
RomainMuller
added a commit
that referenced
this issue
Jul 3, 2018
Breaking down the monolithic CLI infrastructure by using `yarg`'s `commandDir` directive (see #176). This allows modelling each command in a separate module for a cleaner interface. Migrated the `docs` command, and created a prototype of a `doctor` command (see #154). The new commands also have basic unit tests that verify the handlers honor their promises.
RomainMuller
added a commit
that referenced
this issue
Jul 3, 2018
Breaking down the monolithic CLI infrastructure by using `yarg`'s `commandDir` directive (see #176). This allows modelling each command in a separate module for a cleaner interface. Migrated the `docs` command, and created a prototype of a `doctor` command (see #154). The new commands also have basic unit tests that verify the handlers honor their promises.
srchase
added
feature-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current CLI code is mostly untested and consists in a large monolith that handles different commands. The output of
cdk --helpalso makes incorrect claims (for example that--appis unconditionally mandatory, when it is only for certain commands).The proposal is to re-factor using
yarg'scommandDirdirective, and introducing unit tests as we are migrating commands from the current state to the new paradigm.We should also consider whether it makes sense to interactively collect additional information from the user instead of bailing out, for scenarios where that makes sense (no default region defined, ...).
The text was updated successfully, but these errors were encountered: