Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-elasticloadbalancingv2-targets): stickiness.enabled not supported for HTTPS target group type #17774

Closed
jaecktec opened this issue Nov 30, 2021 · 4 comments
Assignees
Labels
@aws-cdk/aws-elasticloadbalancingv2-targets bug This issue is a bug. effort/small Small work item – less than a day of effort p1

Comments

@jaecktec
Copy link
Contributor

jaecktec commented Nov 30, 2021

What is the problem?

When creating an ApplicationTargetGroup for a LambdaTarget by using the new ApplicationTargetGroup({...}) constructor,
stickiness.enabled is by default specified (true/false), but is not supported for a 'HTTPS' target group type

Reproduction Steps

const applicationTargetGroup = new ApplicationTargetGroup(this, 'tg', {
  vpc,
  targetGroupName: `ECS-TG`,
  targets: [new LambdaTarget(func)],
});

httpsListener.addTargetGroups('target', {
  conditions: [ListenerCondition.pathPatterns([
    ...
  ])],
  priority: ...
  targetGroups: [applicationTargetGroup],
});

What did you expect to happen?

Should create a TargetGroup that works with LambdaTargets

What actually happened?

Creates a TargetGroup with

stickiness.enabled = "true"

CDK CLI Version

2.0.0-rc.33 (build 336ff5e)

Framework Version

No response

Node.js Version

v14.16.1

OS

macOS Big Sur 11.4

Language

Typescript

Language Version

3.9.10

Other information

It can be worked-around by manually deleting this option:

applicationTargetGroup.setAttribute('stickiness.enabled', undefined)
@jaecktec jaecktec added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 30, 2021
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Nov 30, 2021
@ryparker ryparker changed the title (module name): short issue description (aws-elasticloadbalancingv2-targets): stickiness.enabled not supported for HTTPS target group type Nov 30, 2021
@ryparker ryparker added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 labels Nov 30, 2021
@ilko-rbi
Copy link

ilko-rbi commented Dec 1, 2021

same here with v1.134.0 - here the link to the documentation for the supported attributes on a Target Group

@njlynch njlynch added p1 and removed p2 labels Dec 1, 2021
@njlynch
Copy link
Contributor

njlynch commented Dec 1, 2021

Related to #17111 and #17271.

Thanks for the links to the docs, @ilko-rbi

@njlynch
Copy link
Contributor

njlynch commented Dec 1, 2021

Ah, at closer inspection, this is identical to what was fixed by #17271. This fix has not yet been ported up to v2, but should go out with the v2 release next week.

@njlynch njlynch closed this as completed Dec 1, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-elasticloadbalancingv2-targets bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

No branches or pull requests

4 participants