fix(elasticloadbalancingv2): always set stickiness

[iRoachie]

CloudFormation does not process the removal of the stickiness attribute from the template as a delta that needs to be processed.

This results in scenarios where if a property was set in an application, that removing it would have no effect.

The fix to this is to always explicitly set the property so that a delta is always processed.

Fixes #16620

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[iRoachie]

@njlynch @rix0rrr any idea how I would update this integ? It creates a record on route53 and a cert but this fails obviously cause I don't have example.com in my route53 especially with an id of fakeId. https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/aws-ecs-patterns/test/fargate/integ.alb-fargate-service-https.ts#L25

The deployment fails with:

DNS Record Set is not available. Certificate is in FAILED status.

[njlynch]

@iRoachie -

This is one of those cases where it's impossible to have an integ test that everyone can validate. I believe the standard is that if you happen to have a route53 hosted zone and certificate you can use/request, fill in the blanks, verify deployment, and then revert the changes to the zone/cert. In this case, given the rest of the integ tests have been done, I think we can cheat this one a bit and use the --dry-run flag of cdk-integ to update:

% npx cdk-integ --dry-run integ.alb-fargate-service-https.ts

This updates the expected file without deploying; not optimal, but acceptable in this case (I think).

[iRoachie]

Ahh good to know. Went with the --dry-run option

[iRoachie]

Alright @njlynch i think we have finally updated all the integ tests 😆

[njlynch]

Thanks for the mountain of integ test updates!

Looking at the implementation again, I'm not totally happy with the public API changes. Take a look at my proposal, and let me know what you think.

Pull request has been modified.

[iRoachie]

@njlynch passing 🚀

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: 76ae067
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[pradeepviswanathan]

This breaks the creation of lambda based target groups. Seems like lambda based target groups doesnt expect stickiness to be provided at all. This is the related error - The provided target group attribute is not supported (Service: AmazonElasticLoadBalancing

[iRoachie]

@pradeepviswanathan let's track it another issue