Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(s3): Add support for BucketOwnerEnforced to S3 ObjectOwnership Type #17926

Closed
2 tasks
mp365 opened this issue Dec 9, 2021 · 1 comment · Fixed by #17961
Closed
2 tasks

(s3): Add support for BucketOwnerEnforced to S3 ObjectOwnership Type #17926

mp365 opened this issue Dec 9, 2021 · 1 comment · Fixed by #17961
Labels
@aws-cdk/aws-s3 Related to Amazon S3 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p1

Comments

@mp365
Copy link

mp365 commented Dec 9, 2021

Description

Object Ownership for an S3 bucket has three settings that you can use to control ownership of objects uploaded to a bucket and to disable or enable ACLs. The AWS recommended setting for object ownership is Bucker Owner Enforced. This is also reflected in the AWS S3 Console in the 'Edit Object Permissions' modal accessible from an S3 buckets 'Permissions' tab.

The CDK ObjectOwnership Type currently offers two of the options in its list of members.

The request is to add support for the third option BucketOwnerEnforced. This value is already available in the Cloud Formation AWS::S3::Bucket OwnershipControlsRule resource.

Use Case

Allow us to use the AWS recommended setting for S3 bucket object ownership when creating s3 buckets.

Proposed Solution

Add BucketOwnerEnforced to the bucket ObjectOwnership enum :

export enum ObjectOwnership {
/**
* Objects uploaded to the bucket change ownership to the bucket owner .
*/
BUCKET_OWNER_PREFERRED = 'BucketOwnerPreferred',
/**
* The uploading account will own the object.
*/
OBJECT_WRITER = 'ObjectWriter',
}

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@mp365 mp365 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 9, 2021
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Dec 9, 2021
@otaviomacedo otaviomacedo added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p1 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 9, 2021
@otaviomacedo otaviomacedo removed their assignment Dec 9, 2021
JonBlauvelt pushed a commit to JonBlauvelt/aws-cdk that referenced this issue Dec 11, 2021
JonBlauvelt pushed a commit to JonBlauvelt/aws-cdk that referenced this issue Dec 11, 2021
JonBlauvelt pushed a commit to JonBlauvelt/aws-cdk that referenced this issue Dec 13, 2021
JonBlauvelt pushed a commit to JonBlauvelt/aws-cdk that referenced this issue Dec 13, 2021
@mergify mergify bot closed this as completed in #17961 Dec 13, 2021
mergify bot pushed a commit that referenced this issue Dec 13, 2021
…ipType (#17961)

closes #17926

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
…ipType (aws#17961)

closes aws#17926

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-s3 Related to Amazon S3 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants