-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(CLI): show the time it takes for cdk deploy
(including when running cdk watch
) to finish
#18213
Comments
I actually feel like this is reinventing the wheel a little bit, specifically for I thought we might just do this for aws-cdk/packages/aws-cdk/lib/cdk-toolkit.ts Line 302 in dee732d
Happy to do it for |
I agree it's not great if we simply write out the total time. So why don't we spice things up a little bit? 😃 What if we divided the different phases of deploy, and printed out the time for each of them? For example, the time to So, the output would be something like:
Thoughts on this idea? |
In this vein: I'd appreciate a performance tracing mode for synthesis because I find it difficult to tell which parts of my cdk app (probably bundling assets, but which?) are slowing my synth down. |
Keeps track of how long `cdk deploy` steps take. Times synthesis time along with actual deploy time. Result is something like this: ![Screen Shot 2021-12-30 at 2 32 24 PM](https://user-images.githubusercontent.com/36202692/147782736-bc68d41f-4a9a-4cc9-b623-b7a27e44c10e.png) No tests because all I'm adding is print statements. Closes #18213. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Keeps track of how long `cdk deploy` steps take. Times synthesis time along with actual deploy time. Result is something like this: ![Screen Shot 2021-12-30 at 2 32 24 PM](https://user-images.githubusercontent.com/36202692/147782736-bc68d41f-4a9a-4cc9-b623-b7a27e44c10e.png) No tests because all I'm adding is print statements. Closes aws#18213. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Description
Let's print out the total time it takes for
cdk deploy
to finish, including when a deployment happens throughcdk watch
.This will allows us to brag more easily about how quickly hotswapping works 😃.
Use Case
Showing the speedup hotswap deployments offer.
Proposed Solution
Print out the time it takes for deployment to finish in the CDK CLI.
Other information
Print out the total time
Acknowledge
The text was updated successfully, but these errors were encountered: