fix(assertions): object partiality is dropped passing through arrays #18525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`objectLike()` imposes partial object matching. That means that we don't
need to fully specify all properties of an object to match it, but
just the properties we care about (all other properties can have any
value).
Partial object matching is inherited. That means that in nested
objects, the partiality is maintained:
```ts
objectLike({
x: 'x',
inner: {
// Matches any object that has AT LEAST an 'y' property
y: 'y',
}
})
```
However, the partiality is dropped when passing through arrays:
```ts
objectLike({
x: 'x',
inner: [
{
// Matches any object that has ONLY an 'y' property
y: 'y',
}
],
})
```
This is both unintuitive and different from past behavior, which makes
migrating tests unnecessarily hard.
Fix the discrepancy.
github-actions
bot
added
the
@aws-cdk/assertions
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
kaizencc
approved these changes
Jan 19, 2022
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ws#18525) `objectLike()` imposes partial object matching. That means that we don't need to fully specify all properties of an object to match it, but just the properties we care about (all other properties can have any value). Partial object matching is inherited. That means that in nested objects, the partiality is maintained: ```ts objectLike({ x: 'x', inner: { // Matches any object that has AT LEAST an 'y' property y: 'y', } }) ``` However, the partiality is dropped when passing through arrays: ```ts objectLike({ x: 'x', inner: [ { // Matches any object that has ONLY an 'y' property y: 'y', } ], }) ``` This is both unintuitive and different from past behavior, which makes migrating tests unnecessarily hard. Fix the discrepancy. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
objectLike()imposes partial object matching. That means that we don'tneed to fully specify all properties of an object to match it, but
just the properties we care about (all other properties can have any
value).
Partial object matching is inherited. That means that in nested
objects, the partiality is maintained:
However, the partiality is dropped when passing through arrays:
This is both unintuitive and different from past behavior, which makes
migrating tests unnecessarily hard.
Fix the discrepancy.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license