Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cfn-include): migrate all tests to Assertions #18537

Merged
merged 10 commits into from
Jan 20, 2022

Conversation

comcalvi
Copy link
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@comcalvi comcalvi requested review from skinny85 and kaizencc January 19, 2022 19:12
@gitpod-io
Copy link

gitpod-io bot commented Jan 19, 2022

@github-actions github-actions bot added the @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package label Jan 19, 2022
@comcalvi comcalvi added pr/do-not-merge This PR should not be merged at this time. and removed @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package labels Jan 19, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 19, 2022
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, just a few minor notes!

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, 3 minor things.

@comcalvi comcalvi requested a review from skinny85 January 19, 2022 23:29
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection 🤌

@comcalvi comcalvi removed the pr/do-not-merge This PR should not be merged at this time. label Jan 19, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e913187 into aws:master Jan 20, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 89bf1d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

kornicameister added a commit to kornicameister/aws-cdk that referenced this pull request Jan 20, 2022
* origin/master:
  chore(ecr): migrate to Assertions (aws#18538)
  chore(codepipeline): migrate tests to assertions (aws#18545)
  chore(cfn-include): migrate all tests to Assertions (aws#18537)
  chore: move decdk to cdklabs (aws#18529)
  chore(cloudwatch-actions): migrate to Assertions (aws#18539)
  chore(globalaccelerator): migrate tests to `assertions` (aws#18532)
  chore(config): migrate tests to `assertions` (aws#18533)
  chore(docdb): migrate tests to use the Assertions module (aws#18518)
  chore: npm-check-updates && yarn upgrade (aws#18528)
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants