-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cfn-include): migrate all tests to Assertions #18537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, just a few minor notes!
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, 3 minor things.
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfection 🤌
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
* origin/master: chore(ecr): migrate to Assertions (aws#18538) chore(codepipeline): migrate tests to assertions (aws#18545) chore(cfn-include): migrate all tests to Assertions (aws#18537) chore: move decdk to cdklabs (aws#18529) chore(cloudwatch-actions): migrate to Assertions (aws#18539) chore(globalaccelerator): migrate tests to `assertions` (aws#18532) chore(config): migrate tests to `assertions` (aws#18533) chore(docdb): migrate tests to use the Assertions module (aws#18518) chore: npm-check-updates && yarn upgrade (aws#18528)
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license