Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-eks): Can't enable control plane logging for fargate cluster #19302

Closed
dza89 opened this issue Mar 9, 2022 · 2 comments · Fixed by #20707
Closed

(aws-eks): Can't enable control plane logging for fargate cluster #19302

dza89 opened this issue Mar 9, 2022 · 2 comments · Fixed by #20707
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p1

Comments

@dza89
Copy link

dza89 commented Mar 9, 2022

What is the problem?

This MR added the ability to enable control plane logging for eks clusters. This doesn't work for a fargate cluster because the ClusterProps interface is not included in FargateCluster.

Can I make an MR where I move ClusterLogging to ClusterOptions? Also open to other solutions of course.
I thought I would ask and wait for your input first.

Reproduction Steps

Try to add

const cluster = new eks.FargateCluster(this, 'Cluster', {
  // ...
  version: eks.KubernetesVersion.V1_21,
  clusterLogging: [
    eks.ClusterLoggingTypes.API,
    eks.ClusterLoggingTypes.AUTHENTICATOR,
    eks.ClusterLoggingTypes.SCHEDULER,
  ],
});

and see if it works.

What did you expect to happen?

Enabling logging for fargate clusters would be possible as well

What actually happened?

Nothing.

CDK CLI Version

2.14

Framework Version

No response

Node.js Version

16.13.2

OS

MacOs

Language

Typescript

Language Version

4.6.2

Other information

No response

@dza89 dza89 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 9, 2022
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Mar 9, 2022
@otaviomacedo
Copy link
Contributor

Can I make an MR where I move ClusterLogging to ClusterOptions? Also open to other solutions of course.
I thought I would ask and wait for your input first.

Sounds good.

@otaviomacedo otaviomacedo added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Mar 9, 2022
@otaviomacedo otaviomacedo removed their assignment Mar 9, 2022
@otaviomacedo otaviomacedo added the good first issue Related to contributions. See CONTRIBUTING.md label Mar 9, 2022
@mergify mergify bot closed this as completed in #20707 Jun 13, 2022
mergify bot pushed a commit that referenced this issue Jun 13, 2022
Fixes #19302
----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

daschaa pushed a commit to daschaa/aws-cdk that referenced this issue Jul 9, 2022
Fixes aws#19302
----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants