Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdk doctor potentially exposes secrets #1931

Closed
eladb opened this issue Mar 3, 2019 · 0 comments · Fixed by #2357 · May be fixed by MechanicalRock/account-reaper#6
Closed

cdk doctor potentially exposes secrets #1931

eladb opened this issue Mar 3, 2019 · 0 comments · Fixed by #2357 · May be fixed by MechanicalRock/account-reaper#6
Assignees
@RomainMuller @rix0rrr
Labels
effort/small Small work item – less than a day of effort p0 package/tools Related to AWS CDK Tools or CLI SECURITY

Comments

@eladb
Copy link
Contributor

eladb commented Mar 3, 2019

cdk doctor emits all environment variables that begin with AWS_, including AWS credentials.
@eladb eladb added SECURITY package/tools Related to AWS CDK Tools or CLI labels Mar 3, 2019
@fulghum fulghum added the p0 label Mar 26, 2019
@fulghum fulghum added the effort/small Small work item – less than a day of effort label Apr 22, 2019
rix0rrr added a commit that referenced this issue Apr 23, 2019
@rix0rrr
fix(toolkit): stop 'cdk doctor' from printing AWS_ variables
768c84e 
Fixes #1931.
@rix0rrr rix0rrr mentioned this issue Apr 23, 2019
Merged
4 tasks
@rix0rrr rix0rrr self-assigned this Apr 23, 2019
rix0rrr added a commit that referenced this issue Apr 23, 2019
@rix0rrr
fix(toolkit): stop 'cdk doctor' from printing AWS_ variables (#2357)
6209c6b 
Fixes #1931.
piradeepk pushed a commit to piradeepk/aws-cdk that referenced this issue Apr 25, 2019
@rix0rrr @piradeepk
fix(toolkit): stop 'cdk doctor' from printing AWS_ variables (aws#2357)
361d6d0 
Fixes aws#1931.
SanderKnape pushed a commit to SanderKnape/aws-cdk that referenced this issue May 14, 2019
@rix0rrr @SanderKnape
fix(toolkit): stop 'cdk doctor' from printing AWS_ variables (aws#2357)
d5ac172 
Fixes aws#1931.
This was referenced Dec 12, 2019
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

@rix0rrr rix0rrr

Labels
effort/small Small work item – less than a day of effort p0 package/tools Related to AWS CDK Tools or CLI SECURITY
Projects
None yet
Milestone
No milestone
4 participants
@fulghum @RomainMuller @rix0rrr @eladb