-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-cloudfront): sslSupportMethod is not defined #19476
Comments
Hey @dayjournal 👋🏻 Thanks for opening the issue and for linking the relevant CDK code. I'm going to convert this into a feature-request as it is not currently supported in the Meanwhile if you're in need of a workaround you can utilize an escape hatch to override the final CloudFormation template that CDK outputs. e.g. // Override `SslSupportMethod` until Issue #19476 is resolved.
const cfnDistribution = distribution.node.defaultChild as CfnDistribution;
cfnDistribution.addPropertyOverride(
"DistributionConfig.ViewerCertificate.SslSupportMethod",
SSLMethod.VIP
); |
- Modified to allow selection of sslSupportMethod closes aws#19476
- Add test for sslSupportMethod - Corrected comment closes aws#19476
- Modified to allow selection of sslSupportMethod closes #19476 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
- Modified to allow selection of sslSupportMethod closes #19476 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Modified to allow selection of sslSupportMethod closes aws#19476 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
What is the problem?
Cannot specify
sslSupportMethod
forCloudFront Distribution
indistribution.ts
.I can specify
minimumProtocolVersion
but notsslSupportMethod
.Example of
minimumProtocolVersion
https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-cloudfront/lib/distribution.ts#L222
https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-cloudfront/lib/distribution.ts#L537
Example of
sslSupportMethod
https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-cloudfront/lib/distribution.ts#L528
Reproduction Steps
What did you expect to happen?
I want to set
sslSupportMethod
.What actually happened?
I can't configure it with the new method
CloudFront Distribution
.It seems to be possible with the old method
CloudFrontWebDistribution
.CDK CLI Version
v2.15.0
Framework Version
v2.15.0
Node.js Version
v16.10.0
OS
M1 Mac (macOS Monterey v12.2.1)
Language
Typescript
Language Version
v3.9.7
Other information
No response
The text was updated successfully, but these errors were encountered: