Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-eks): It should be possible to pass annotations to service accounts #19607

Closed
1 of 2 tasks
markussiebert opened this issue Mar 29, 2022 · 1 comment · Fixed by #19609
Closed
1 of 2 tasks

(aws-eks): It should be possible to pass annotations to service accounts #19607

markussiebert opened this issue Mar 29, 2022 · 1 comment · Fixed by #19609
Assignees
@otaviomacedo
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1

Comments

@markussiebert
Copy link
Contributor

markussiebert commented Mar 29, 2022 •
edited
Loading

Description

I need to add annotations and labels to ServiceAccounts created via cdk

Use Case

eks changed the behaviour of the service accounts for pods, and one of my applications stopped working.

https://docs.aws.amazon.com/eks/latest/userguide/specify-service-account-role.html

and i temporarly (until this is fixed in the application) have to annotate the ServiceAccount with:

eks.amazonaws.com/sts-regional-endpoints: false

in order to enforce the old behaviour. I can imagine more annotations, or labels...

Proposed Solution

introduce properties for annotations and labels

Other information

no

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@markussiebert markussiebert added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 29, 2022
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Mar 29, 2022
@markussiebert markussiebert mentioned this issue Mar 29, 2022
Merged
1 task
@peterwoodworth peterwoodworth added p1 effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 31, 2022
@mergify mergify bot closed this as completed in #19609 Apr 26, 2022
mergify bot pushed a commit that referenced this issue Apr 26, 2022
@markussiebert
feat(aws-eks): add annotations and labels to service accounts (#19609)
82aec9d 
I have added two optional props for the serviceaccount:

* annotations
* labels

at the moment, both aren't accessible. It's possible to create kubernetes patches for this, but the same time it's only a small change to enable both options in a backward compatible way.

fixes #19607

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

no

### New Features

* I have added an unit test for the extended properties 

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otaviomacedo otaviomacedo

Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-eks): add annotations and labels to service accounts markussiebert/aws-cdk
3 participants
@otaviomacedo @markussiebert @peterwoodworth