-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aws-batch] missing launchTemplateId in LaunchTemplateSpecification #20163
Labels
@aws-cdk/aws-batch
Related to AWS Batch
feature-request
A feature should be added or improved.
in-progress
This issue is being actively worked on.
Comments
4 tasks
@TheRealAmazonKendra @madeline-k Looks like there's a PR that addresses this. Can we get review on that? |
mergify bot
pushed a commit
that referenced
this issue
Jul 7, 2022
) Closes #20163 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this issue
Jul 9, 2022
…#20184) Closes aws#20163 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-batch
Related to AWS Batch
feature-request
A feature should be added or improved.
in-progress
This issue is being actively worked on.
Describe the feature
Add support for
launchTemplateId
when attaching a launchTemplate to a Batch Compute environment. Currently it requires using a launchTemplateName.This should be supported: https://docs.aws.amazon.com/batch/latest/APIReference/API_LaunchTemplateSpecification.html
Use Case
I would like to stop naming resources explicitly as per CDK best practice and let CDK handle naming the launch template.
Proposed Solution
No response
Other Information
No response
Acknowledgements
CDK version used
1.153.1
Environment details (OS name and version, etc.)
Amazon Linux 2
The text was updated successfully, but these errors were encountered: