Consider splitting @aws-cdk/core to multiple modules #204
Labels
@aws-cdk/core
Related to core CDK functionality
feature-request
A feature should be added or improved.
Comments
srchase
added
feature-request
HBobertz
added a commit
that referenced
this issue
Feb 1, 2024
* initial jazz integration * cdk migrate with jazz integration * delete unused tests * move comment to appropriate test * refactor + comments to make it more readable * add filter ts doc * fix the test * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * minor refactors * make the progress bar safer * fix test * changes to managed flag pruning * Update packages/aws-cdk/lib/cdk-toolkit.ts Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * resolve conflicts * or/and functionality * refactor user experience * display time since last scan * add user agent to cfn calls * make resources more statically typed * update and fix flitering * refactor template generator experience * refactor code * fix cli options * adjust apis to reflect template generator changes * update model * update tests * updated tests * fixes for migrate tests * fix generate template test mock * add failure test for most-recent * add filter failure test * feat(migrate): add migrate.json file creation to migrate workflow for imports (#212) * write file migrate.json to output * simplified source options * fixing tests * fix tests * fix test conflict and refactor tests * remove commented out test * add filter fail test * add default start test * add test for successful filters * remove duplicate test * update testing for import * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Kendra Neil <53584728+TheRealAmazonKendra@users.noreply.github.com> * add test for migrate.json * add tests for migrate.json creation * remove dumb comment I put in --------- Co-authored-by: Hogan Bobertz <bobertzh@amazon.com> Co-authored-by: Kendra Neil <53584728+TheRealAmazonKendra@users.noreply.github.com> * readd comment * add additional tests and address feedback * update error message * update test to no longer clean up generated templates * comment out test for now * address feedback * address feedback and refactor * remove bangs --------- Co-authored-by: Hogan Bobertz <bobertzh@amazon.com> Co-authored-by: Rico Hermans <rix0rrr@gmail.com> Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com> Co-authored-by: Kendra Neil <53584728+TheRealAmazonKendra@users.noreply.github.com>
HBobertz
added a commit
that referenced
this issue
Feb 1, 2024
* initial jazz integration * cdk migrate with jazz integration * delete unused tests * move comment to appropriate test * refactor + comments to make it more readable * add filter ts doc * fix the test * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * minor refactors * make the progress bar safer * fix test * changes to managed flag pruning * Update packages/aws-cdk/lib/cdk-toolkit.ts Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com> * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Rico Hermans <rix0rrr@gmail.com> * resolve conflicts * or/and functionality * refactor user experience * display time since last scan * add user agent to cfn calls * make resources more statically typed * update and fix flitering * refactor template generator experience * refactor code * fix cli options * adjust apis to reflect template generator changes * update model * update tests * updated tests * fixes for migrate tests * fix generate template test mock * add failure test for most-recent * add filter failure test * feat(migrate): add migrate.json file creation to migrate workflow for imports (#212) * write file migrate.json to output * simplified source options * fixing tests * fix tests * fix test conflict and refactor tests * remove commented out test * add filter fail test * add default start test * add test for successful filters * remove duplicate test * update testing for import * Update packages/aws-cdk/lib/commands/migrate.ts Co-authored-by: Kendra Neil <53584728+TheRealAmazonKendra@users.noreply.github.com> * add test for migrate.json * add tests for migrate.json creation * remove dumb comment I put in --------- Co-authored-by: Hogan Bobertz <bobertzh@amazon.com> Co-authored-by: Kendra Neil <53584728+TheRealAmazonKendra@users.noreply.github.com> * readd comment * add additional tests and address feedback * update error message * update test to no longer clean up generated templates * comment out test for now * address feedback * address feedback and refactor * remove bangs --------- Co-authored-by: Hogan Bobertz <bobertzh@amazon.com> Co-authored-by: Rico Hermans <rix0rrr@gmail.com> Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com> Co-authored-by: Kendra Neil <53584728+TheRealAmazonKendra@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Forked off #202 by @rclark:
It might be worth considering splitting up '@aws-cdk/core' into smaller libraries. The reference docs are hard to browse because so much is included in this library, and I tend to end up with a very long list of imports from this lib.
For example, it might be worth breaking out intrinsic functions and pseudo parameters. Quick and easy access to these tends to be pretty important in my experience with CloudFormation.
The text was updated successfully, but these errors were encountered: