Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(init-templates): Delete some line no longer needed by ts-node in typescript template #20754

Closed
1 of 2 tasks
yamatatsu opened this issue Jun 15, 2022 · 1 comment · Fixed by #32113
Closed
1 of 2 tasks

(init-templates): Delete some line no longer needed by ts-node in typescript template #20754

yamatatsu opened this issue Jun 15, 2022 · 1 comment · Fixed by #32113
Labels
cli Issues related to the CDK CLI feature-request A feature should be added or improved. p2

Comments

@yamatatsu
Copy link
Contributor

Describe the feature

Now, The template of typescript has some unnecessary lines.
The following seems a bit misleadable.

Use Case

This modifying make the templates simple.

Proposed Solution

  • remove shebang from the bin file
  • remove using source-map-support/register
  • remove two npm scripts "build": "tsc" and "watch": "tsc -w" from package.json

The target of these should be app and sample-app only, not lib.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.28.0

Environment details (OS name and version, etc.)

macOS 12.4
@yamatatsu yamatatsu added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 15, 2022
@yamatatsu yamatatsu changed the title (init-templates): Delete no longer needed by ts-node in typescript template (init-templates): Delete some line no longer needed by ts-node in typescript template Jun 15, 2022
@NGL321 NGL321 added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jun 23, 2022
@moelasmar moelasmar added the cli Issues related to the CDK CLI label Aug 28, 2024
@mrgrain mrgrain mentioned this issue Nov 13, 2024
Merged
1 task
@mergify mergify bot closed this as completed in #32113 Nov 14, 2024
mergify bot pushed a commit that referenced this issue Nov 14, 2024
@mrgrain
fix(cdk): remove source-map-support from typescript init templates (#…
d5c0aa2 
…32113)

### Issue

Closes #20754
Closes #30231

### Reason for this change

This package is no longer needed and not recommended for users.

### Description of changes

Remove the package from `package.json` and sample code.

### Description of how you validated changes

Tested locally.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cli Issues related to the CDK CLI feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cdk): remove source-map-support from typescript init templates aws/aws-cdk
4 participants
@NGL321 @yamatatsu @peterwoodworth @moelasmar