-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(@aws-cdk/aws-glue-alpha): Add partition_filtering.enabled support #20825
Comments
The proposed solution is good. I would be happy to take a contribution on this. I'd call the prop |
@kaizencc Yes, I would like to try it! |
Fixes #20825 Adds `partition_filtering.enabled` to `TableProps` in AWS Glue. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Describe the feature
Table construct support partition indexes. However, the feature to set
partition_filtering.enabled: true
to enable partition filtering is missing.https://docs.aws.amazon.com/athena/latest/ug/glue-best-practices.html#glue-best-practices-partition-index
It would be nice if Table construct provide the way to set
partition_filtering.enabled
property.Use Case
I always manually add
partition_filtering.enabled: true
after creating the table.It would helpful if I can add the property with Table construct.
Proposed Solution
How about adding a
partitionFilteringEnable
prop to TableProps and setting parameters likeclassification
andhas_encrypted_data
?aws-cdk/packages/@aws-cdk/aws-glue/lib/table.ts
Lines 304 to 307 in 74318c7
Other Information
No response
Acknowledgements
CDK version used
2.28.1
Environment details (OS name and version, etc.)
Windows
The text was updated successfully, but these errors were encountered: