Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitpod not prebuild correctly #21063

Closed
pahud opened this issue Jul 8, 2022 · 2 comments · Fixed by #21064
Closed

gitpod not prebuild correctly #21063

pahud opened this issue Jul 8, 2022 · 2 comments · Fixed by #21064
Assignees
Labels
@aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1

Comments

@pahud
Copy link
Contributor

pahud commented Jul 8, 2022

Describe the bug

When opening the repo with GitPod, it throws the prebuild error

image

Expected Behavior

to prebuild correctly with no error

Current Behavior

gitpod@aws-awscdk-mork8kacwjx:/workspace/aws-cdk$ HISTFILE=/workspace/.gitpod/cmd-0 history -r; {

[ -r /workspace/.prebuild-log-0 ] && cat /workspace/.prebuild-log-0; [ -r /workspace/.gitpod/prebuild-log-0 ] && cat /workspace/.gitpod/prebuild-log-0; true
}
{
yarn build --skip-test --no-bail --skip-prereqs --skip-compat
}; exit
gitpod@aws-awscdk-r68tfij2ejz:/workspace/aws-cdk$ {
yarn build --skip-test --no-bail --skip-prereqs --skip-compat
}; exit
yarn run v1.22.19
$ node ./scripts/check-yarn-lock.js
internal/modules/cjs/loader.js:905
throw err;
^

Error: Cannot find module '@lerna/project'
Require stack:

  • /workspace/aws-cdk/scripts/check-yarn-lock.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
    at Function.Module._load (internal/modules/cjs/loader.js:746:27)
    at Module.require (internal/modules/cjs/loader.js:974:19)
    at require (internal/modules/cjs/helpers.js:101:18)
    at Object. (/workspace/aws-cdk/scripts/check-yarn-lock.js:17:21)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:75:12) {
    code: 'MODULE_NOT_FOUND',
    requireStack: [ '/workspace/aws-cdk/scripts/check-yarn-lock.js' ]
    }
    error Command failed with exit code 1.
    info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
    exit

🤙 This task ran as a workspace prebuild

Reproduction Steps

Just open this repo with GitPod

Possible Solution

Modify the init task here

- init: yarn build --skip-test --no-bail --skip-prereqs --skip-compat

to have it execute:

yarn install && ./scripts/foreach.sh yarn build

Additional Information/Context

No response

CDK CLI Version

latest

Framework Version

No response

Node.js Version

all

OS

gitpod

Language

Typescript

Language Version

No response

Other information

No response

@pahud pahud added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 8, 2022
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Jul 8, 2022
@pahud
Copy link
Contributor Author

pahud commented Jul 8, 2022

I will try fix this with a PR.

@peterwoodworth peterwoodworth added p1 effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Jul 8, 2022
@mergify mergify bot closed this as completed in #21064 Jul 14, 2022
mergify bot pushed a commit that referenced this issue Jul 14, 2022
This PR fixes the init task in `.gitpod.yml` for gitpod to correctly prebuild and remove the eslint static version pinning.

Fixes: #21063 

----

### All Submissions:

* [v] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants