-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-fsx): autoImportPolicy cannot be set in LustreConfiguration #21288
Labels
@aws-cdk/aws-fsx
Related to Amazon FSx
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p1
Comments
mergify bot
pushed a commit
that referenced
this issue
Jul 28, 2022
---- closes #21288 The LustreFilesystem construct already supports a backing S3 bucket, through the importPath/exportPath parameters. CloudFormation supports an AutoImportPolicy parameter, to perform this import automatically and continuously if required. Currently, the L2 construct does not allow this parameter to be set. This PR adds that capability. ### All Submissions: * [yes] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [no] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [yes] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [yes] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
josephedward
pushed a commit
to josephedward/aws-cdk
that referenced
this issue
Aug 30, 2022
---- closes aws#21288 The LustreFilesystem construct already supports a backing S3 bucket, through the importPath/exportPath parameters. CloudFormation supports an AutoImportPolicy parameter, to perform this import automatically and continuously if required. Currently, the L2 construct does not allow this parameter to be set. This PR adds that capability. ### All Submissions: * [yes] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [no] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [yes] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [yes] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-fsx
Related to Amazon FSx
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p1
Describe the feature
Add autoImportPolicy support to LustreConfiguration
Use Case
If a Lustre filesystem is backed by S3, it's important to be able to set the policy as to what happens to the visibility of files in Lustre if the S3 bucket changes. This is important for enabling the user to dynamically destroy and recreate the FSx filesystem independently of the bucket, and thus save costs.
CloudFormation supports this through setting AutoImportPolicy in the LustreConfiguration.
Proposed Solution
This would allow CDK code something like this:
Other Information
I have already implemented this, together with tests.
Acknowledgements
CDK version used
2.33.0
Environment details (OS name and version, etc.)
Mac OS X 10.15
The text was updated successfully, but these errors were encountered: