Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws_ec2): (add batch to InterfaceVpcEndpointAwsService) #21338

Closed
1 of 2 tasks
shimi7o opened this issue Jul 27, 2022 · 3 comments
Closed
1 of 2 tasks

(aws_ec2): (add batch to InterfaceVpcEndpointAwsService) #21338

shimi7o opened this issue Jul 27, 2022 · 3 comments
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@shimi7o
Copy link
Contributor

shimi7o commented Jul 27, 2022

Describe the feature

My request is to add batch to InterfaceVpcEndpointAwsService.

    declare const vpc: ec2.Vpc;

    new ec2.InterfaceVpcEndpoint(
      this,
      'VpcEndpoint',
      {
        vpc: vpc,
        service: ec2.InterfaceVpcEndpointAwsService.Batch,  // Currently, I can't
      }
    );

Use Case

Currently, I must be written as below.

    declare const vpc: ec2.Vpc;

    new ec2.InterfaceVpcEndpoint(
      this,
      'VpcEndpoint',
      {
        vpc: vpc,
        service: new ec2.InterfaceVpcEndpointService(
          `com.amazonaws.${region}.batch` // not good
        )
      }
    );

Proposed Solution

My idea is to add one line in aws-cdk/packages/@aws-cdk/aws-ec2/lib/vpc-endpoint.ts

export class InterfaceVpcEndpointAwsService implements IInterfaceVpcEndpointService {
  public static readonly BATCH = new InterfaceVpcEndpointAwsService('batch');  

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.33.0

Environment details (OS name and version, etc.)

Debian10.12

@shimi7o shimi7o added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 27, 2022
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Jul 27, 2022
@corymhall
Copy link
Contributor

This issue has been classified as p2. That means a workaround is available or it is deemed a nice-to-have feature. Given the amount of work there is to do and the relative priority of this issue, the CDK team is unlikely to address it. That does not mean the issue will never be fixed! If someone from the community submits a PR to fix this issue, and the PR is small and straightforward enough, and meets the quality bars to be reviewed and merged with little effort we will accept that PR. PRs that do not build or need complex or multiple rounds of reviews are unlikely to be merged and will be closed to keep our backlog manageable.

In the mean time, remember that you can always use the escape hatch (https://docs.aws.amazon.com/cdk/v2/guide/cfn_layer.html) mechanism to have fine control over the CloudFormation output you want. We will keep the issue open for discoverability, to collect upvotes, and to facilitate discussion around this topic.

We use +1s on this issue to help prioritize our work, and are happy to re-evaluate the prioritization of this issue based on community feedback. You can reach out to the cdk.dev community on Slack (https://cdk.dev/) to solicit support for reprioritization.

@corymhall corymhall added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 1, 2022
@corymhall corymhall removed their assignment Aug 1, 2022
mergify bot pushed a commit that referenced this issue Aug 1, 2022
…21401)

This add the following endpoints to `InterfaceVpcEndpointAwsService`:
`codeartifact.api`
`codeartifact.respositories`
`batch`
`autoscaling`
`autoscaling-plan`
`application-autoscaling`


closes #21402 #21220 #21338 #19420
----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@TheRealAmazonKendra
Copy link
Contributor

This has now been completed.

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

josephedward pushed a commit to josephedward/aws-cdk that referenced this issue Aug 30, 2022
…ws#21401)

This add the following endpoints to `InterfaceVpcEndpointAwsService`:
`codeartifact.api`
`codeartifact.respositories`
`batch`
`autoscaling`
`autoscaling-plan`
`application-autoscaling`


closes aws#21402 aws#21220 aws#21338 aws#19420
----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants