Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): Supported resource types are not up-to-date and missing as of 2022.8. #21477

Closed
2 tasks done
watany-dev opened this issue Aug 5, 2022 · 1 comment · Fixed by #21491
Closed
2 tasks done

feat(config): Supported resource types are not up-to-date and missing as of 2022.8. #21477

watany-dev opened this issue Aug 5, 2022 · 1 comment · Fixed by #21491
Assignees
@rix0rrr
Labels
@aws-cdk/aws-config Related to AWS Config feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@watany-dev
Copy link
Contributor

watany-dev commented Aug 5, 2022 •
edited
Loading

Describe the feature

ResourceType in L2 Construct is not maintained and the following properties cannot be selected. I would like to add this.

  • AWS::EC2::NetworkInterface
  • AWS::EC2::TransitGateway
  • AWS::EC2::TransitGatewayAttachment
  • AWS::EC2::TransitGatewayRouteTable
  • AWS::EC2::RegisteredHAInstance
  • AWS::EC2::LaunchTemplate
  • AWS::ECR::Repository
  • AWS::ECR::PublicRepository
  • AWS::ECS::Cluster
  • AWS::ECS::TaskDefinition
  • AWS::ECS::Service
  • AWS::EFS::FileSystem
  • AWS::EFS::AccessPoint
  • AWS::EMR::SecurityConfiguration
  • AWS::GuardDuty::Detector
  • AWS::OpenSearch::Domain
  • AWS::Kinesis::Stream
  • AWS::Kinesis::StreamConsumer
  • AWS::MSK::Cluster
  • AWS::Route53Resolver::ResolverEndpoint
  • AWS::Route53Resolver::ResolverRule
  • AWS::Route53Resolver::ResolverRuleAssociation
  • AWS::SageMaker::CodeRepository
  • AWS::SageMaker::Model
  • AWS::SageMaker::NotebookInstance
  • AWS::WorkSpaces::ConnectionAlias
  • AWS::WorkSpaces::Workspace
  • AWS::Backup::BackupPlan
  • AWS::Backup::BackupSelection
  • AWS::Backup::BackupVault
  • AWS::Backup::RecoveryPoint
  • AWS::Batch::JobQueue
  • AWS::Batch::ComputeEnvironment
  • AWS::CodeDeploy::Application
  • AWS::CodeDeploy::DeploymentConfig
  • AWS::CodeDeploy::DeploymentGroup
  • AWS::Config::ResourceCompliance
  • AWS::Config::ConformancePackCompliance
  • AWS::DMS::EventSubscription
  • AWS::DMS::ReplicationSubnetGroup
  • AWS::GlobalAccelerator::Listener
  • AWS::GlobalAccelerator::EndpointGroup
  • AWS::GlobalAccelerator::Accelerator
  • AWS::AccessAnalyzer::Analyzer
  • AWS::StepFunctions::Activity
  • AWS::StepFunctions::StateMachine
  • AWS::WAFv2::IPSet
  • AWS::WAFv2::RegexPatternSet
  • AWS::ElasticLoadBalancingV2::Listener

Use Case

Cannot be used without reason when you want to specify the above resource

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.35.0

Environment details (OS name and version, etc.)

in any environment
@watany-dev watany-dev added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 5, 2022
@github-actions github-actions bot added the @aws-cdk/aws-config Related to AWS Config label Aug 5, 2022
watany-dev added a commit to watany-dev/aws-cdk that referenced this issue Aug 6, 2022
@watany-dev
aws#21477 add config resourcetype in 202208XX Latest
ced58bc
watany-dev added a commit to watany-dev/aws-cdk that referenced this issue Aug 6, 2022
@watany-dev
aws#21477 add config resourcetype in 202208XX Latest
0392e7c
watany-dev added a commit to watany-dev/aws-cdk that referenced this issue Aug 7, 2022
@watany-dev
aws#21477 add config resourcetype in 202208XX Latest
9b92b3c
@watany-dev watany-dev mentioned this issue Aug 7, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #21491 Aug 7, 2022
mergify bot pushed a commit that referenced this issue Aug 7, 2022
@watany-dev
chore(config): Config resource type upgrade 202208xx (#21491)
618c5bc 
fixes #21477

The original problem was that [Supported Resource Types](https://docs.aws.amazon.com/config/latest/developerguide/resource-config-reference.html) currently does not support resource types.

To solve this problem, type information had to be defined in L2 Constructs. Details are listed in the issue list. (Too many to list again)

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

jmortlock pushed a commit to jmortlock/aws-cdk that referenced this issue Aug 8, 2022
@watany-dev @jmortlock
chore(config): Config resource type upgrade 202208xx (aws#21491)
8edb228 
fixes aws#21477

The original problem was that [Supported Resource Types](https://docs.aws.amazon.com/config/latest/developerguide/resource-config-reference.html) currently does not support resource types.

To solve this problem, type information had to be defined in L2 Constructs. Details are listed in the issue list. (Too many to list again)

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
josephedward pushed a commit to josephedward/aws-cdk that referenced this issue Aug 30, 2022
@watany-dev @josephedward
chore(config): Config resource type upgrade 202208xx (aws#21491)
c24a085 
fixes aws#21477

The original problem was that [Supported Resource Types](https://docs.aws.amazon.com/config/latest/developerguide/resource-config-reference.html) currently does not support resource types.

To solve this problem, type information had to be defined in L2 Constructs. Details are listed in the issue list. (Too many to list again)

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-config Related to AWS Config feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(config): Config resource type upgrade 202208xx watany-dev/aws-cdk
2 participants
@rix0rrr @watany-dev