AutoScalingGroupProps.AssociatePublicIpAddress has no effect

[icelava]

Describe the bug

https://docs.aws.amazon.com/cdk/api/v2/dotnet/api/Amazon.CDK.AWS.AutoScaling.AutoScalingGroupProps.html#Amazon_CDK_AWS_AutoScaling_AutoScalingGroupProps_AssociatePublicIpAddress

Setting property to false still results in instances launched with public IP address.

Expected Behavior

Launched instances should not assign public IP address.

Current Behavior

Launched instances get public IP address.

Reproduction Steps

this.asg = new AutoScalingGroup(this, this.asgName, new AutoScalingGroupProps
{
	AutoScalingGroupName = this.asgName,
	LaunchTemplate = lt,
	Vpc = this._props.Vpc,
	VpcSubnets = this._props.AppSubnets,
	AssociatePublicIpAddress = false,
	MinCapacity = this._props.MinCapacity,
	MaxCapacity = this._props.MaxCapacity,
	DesiredCapacity = this._props.DesiredCapacity
});

Possible Solution

That property should cause a change in the resultant CloudFormation template.

Additional Information/Context

No response

CDK CLI Version

2.35.0

Framework Version

.NET Core 3.1

Node.js Version

NA

OS

Windows

Language

.NET

Language Version

C# 8

Other information

No response

[peterwoodworth]

We're passing this prop directly to the LaunchTemplate resource - You can see a more full description of the underlying behavior of this prop here

That property should cause a change in the resultant CloudFormation template.

Does this mean that if you alternate this value between true and false that you aren't seeing a difference in the resulting template?

[github-actions]

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[icelava]

Yeap it was originally not set, so defaulted to true. When I set it to false, no change in the resulting CloudFormation template.

[peterwoodworth]

This property isn't supposed to be used when passing in your own launch template to a new ASG. We are supposed to throw an error here, but there's a bug in the logic which prevents that. I've made a PR which updates the documentation for all props which can't be used when specifying a launch template, as well as ensures an error gets thrown when this prop is set to false

[icelava]

Hmmm but the LaunchTemplate does not feature such a property?

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.