Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary step in README.md for Python app template #2171

Closed
garnaat opened this issue Apr 3, 2019 · 0 comments · Fixed by #2173
Closed

Unnecessary step in README.md for Python app template #2171

garnaat opened this issue Apr 3, 2019 · 0 comments · Fixed by #2173
Assignees
@garnaat
Labels
language/python Related to Python bindings

Comments

@garnaat
Copy link
Contributor

garnaat commented Apr 3, 2019

The README.md file for the app template used by cdk init --language python contains this:

$ source .env/bin/activate
$ pip install -r requirements.txt
$ python setup.py develop

But that last step is not needed due to the way the requirements.txt is configure. That line should be removed.
@garnaat garnaat added the language/python Related to Python bindings label Apr 3, 2019
@garnaat garnaat self-assigned this Apr 3, 2019
garnaat pushed a commit to garnaat/aws-cdk that referenced this issue Apr 3, 2019
Remove unnecessary line in instructions. Fixes aws#2171.
8faa97b
@garnaat garnaat mentioned this issue Apr 3, 2019
Merged
4 tasks
garnaat added a commit that referenced this issue Apr 3, 2019
@garnaat
Remove unnecessary line in instructions. Fixes #2171. (#2173)
732aa5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garnaat garnaat

Labels
language/python Related to Python bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary line in instructions. garnaat/aws-cdk
1 participant
@garnaat