Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Spot instances #2208

Closed
SoManyHs opened this issue Apr 9, 2019 · 1 comment · Fixed by #2571 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed

Support Spot instances #2208

SoManyHs opened this issue Apr 9, 2019 · 1 comment · Fixed by #2571 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud @aws-cdk/aws-ecs Related to Amazon Elastic Container

Comments

@SoManyHs
Copy link
Contributor

SoManyHs commented Apr 9, 2019

ECS currently supports Spot instance fleets -- to support this feature, we would need Spot instance L2s in ec2 construct lib.
@SoManyHs SoManyHs added @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud @aws-cdk/aws-ecs Related to Amazon Elastic Container labels Apr 9, 2019
SoManyHs added a commit to SoManyHs/aws-cdk that referenced this issue May 17, 2019
@SoManyHs
feat(aws-autoscaling): allow setting spotPrice
c91a49b 
Fixes aws#2208.
@SoManyHs SoManyHs mentioned this issue May 17, 2019
Merged
4 tasks
SoManyHs added a commit to SoManyHs/aws-cdk that referenced this issue May 17, 2019
@SoManyHs
feat(aws-autoscaling): allow setting spotPrice
52b3fa2 
Fixes aws#2208.
@SoManyHs
Copy link
Contributor Author

This can actually be achieved by modifying the properties on the AutoScalingGroup construct; however perhaps worth discussing if AWS::EC2::EC2Fleet and AWS:EC2::SpotFleet are resources worth modeling as L2s?

SoManyHs added a commit to SoManyHs/aws-cdk that referenced this issue May 17, 2019
@SoManyHs
feat(aws-autoscaling): allow setting spotPrice
6fe49bf 
Fixes aws#2208.
SoManyHs added a commit to SoManyHs/aws-cdk that referenced this issue May 23, 2019
@SoManyHs
feat(aws-autoscaling): allow setting spotPrice
c321d2d 
Fixes aws#2208.
rix0rrr pushed a commit that referenced this issue May 29, 2019
@SoManyHs @rix0rrr
feat(autoscaling): allow setting spotPrice (#2571)
d640055 
Fixes #2208.
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Dec 13, 2019
Open
This was referenced Jan 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud @aws-cdk/aws-ecs Related to Amazon Elastic Container
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-autoscaling): allow setting spotPrice SoManyHs/aws-cdk
[Snyk] Upgrade @aws-cdk/aws-iam from 0.22.0 to 0.39.0 MechanicalRock/tech-radar
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-s3 from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-cloudfront from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codecommit from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/cdk from 0.24.1 to 0.35.0 MechanicalRock/account-reaper
1 participant
@SoManyHs