feat(codedeploy): CodeDeploy deployment config constructs for Lambda and ECS #22159

clareliguori · 2022-09-21T02:53:56Z

CloudFormation now supports Lambda and ECS in the AWS::CodeDeploy::DeploymentConfig resource type. This PR adds L2 constructs specific to ECS and Lambda for that resource type.

All Submissions:

Have you followed the guidelines in our Contributing guide?

New Features

Have you added the new feature to an integration test?
- Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…bda and ECS

gitpod-io · 2022-09-21T02:54:04Z

…codedeploy.LambdaDeploymentConfig

cplee · 2022-09-21T05:52:37Z

Looks great! I proposed changes to deprecate the CustomLambdaDeploymentConfig and address the tests.

…onfig chore: deprecate codedeploy.CustomLambdaDeploymentConfig

clareliguori · 2022-09-21T16:08:18Z

Thanks @cplee!

corymhall

I think overall I would like to see an example of how this would be used to deploy an ECS service.
Since the lambda & ecs changes are very simliar I only commented on the ecs changes, but the
comments also apply to lambda as well.

packages/@aws-cdk/aws-codedeploy/lib/ecs/deployment-config.ts

packages/@aws-cdk/aws-codedeploy/lib/traffic-routing-config.ts

packages/@aws-cdk/aws-codedeploy/README.md

packages/@aws-cdk/aws-codedeploy/test/ecs/integ.deployment-config.ts

Pull request has been modified.

clareliguori · 2022-09-26T18:00:42Z

@corymhall I think I addressed all your feedback, expect the pieces that I expect to cover in my next PR (L2 CodeDeploy deployment group constructs for ECS). If you think it would be easier to review deployment config + groups as a single PR, I can merge those changes into this PR.

corymhall

@corymhall I think I addressed all your feedback, expect the pieces that I expect to cover in my next PR (L2 CodeDeploy deployment group constructs for ECS). If you think it would be easier to review deployment config + groups as a single PR, I can merge those changes into this PR.

ah ok if you have another PR for deployment group that will address that then I am fine with holding
on that stuff.

Just a couple of minor comments and then I think we are good!

packages/@aws-cdk/aws-codedeploy/lib/traffic-routing-config.ts

packages/@aws-cdk/aws-codedeploy/lib/ecs/deployment-config.ts

packages/@aws-cdk/aws-codedeploy/lib/traffic-routing-config.ts

Pull request has been modified.

packages/@aws-cdk/aws-codedeploy/lib/ecs/deployment-config.ts

Pull request has been modified.

corymhall

Thanks for your patience on this! Just two minor things and then I think that is it!

packages/@aws-cdk/aws-codedeploy/lib/base-deployment-config.ts

Pull request has been modified.

corymhall

Last one

packages/@aws-cdk/aws-codedeploy/lib/base-deployment-config.ts

Pull request has been modified.

mergify · 2022-09-29T14:56:14Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2022-09-29T15:32:40Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2022-09-29T15:32:52Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: a8112fb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…and ECS (aws#22159) CloudFormation now supports Lambda and ECS in the `AWS::CodeDeploy::DeploymentConfig` resource type. This PR adds L2 constructs specific to ECS and Lambda for that resource type. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

In #22159, a base class for all deployment configs was added. Classes that extended this base were calling static methods returning `IBaseDeploymentConfig` types where previously they returned more specific types, IE `IServerDeploymentConfig`. [This method](6840d8e#diff-93f73231716deb0056687ee155c13d03ccabe2222fd191a33be9caeb7ad87ebaL126) being previously implemented on `IServerDeploymentConfig` but now inheriting from `IBaseDeploymentConfig` caused the return type to change to `IBaseDeploymentConfig` In Typescript, this is fine as [`IServerDeploymentConfig`](6840d8e#diff-93f73231716deb0056687ee155c13d03ccabe2222fd191a33be9caeb7ad87ebaR12) extends `IBaseDeploymentConfig` with no additional properties. So an instance of `IBaseDeploymentConfig` satisfies the `IServerDeploymentConfig` interface implicitly. However, in Java where interfaces are explicit, this caused the error: ``` incompatible types: IBaseDeploymentConfig cannot be converted to IServerDeploymentConfig ``` Where inputs expect the more specific type.

Change all `deploymentConfig` static method implementations on `EcsDeploymentConfig`, `LambdaDeploymentConfig`, and `ServerDeploymentConfig` to return their corresponding specific interfaces instead of `IBaseDeploymentConfig`. This reverts breaking changes to Java users introduced in #22159

Change all `deploymentConfig` static method implementations on `EcsDeploymentConfig`, `LambdaDeploymentConfig`, and `ServerDeploymentConfig` to return their corresponding specific interfaces instead of `IBaseDeploymentConfig`. This reverts breaking changes to Java users introduced in #22159 Fixes #22566 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Change all `deploymentConfig` static method implementations on `EcsDeploymentConfig`, `LambdaDeploymentConfig`, and `ServerDeploymentConfig` to return their corresponding specific interfaces instead of `IBaseDeploymentConfig`. This reverts breaking changes to Java users introduced in aws#22159 Fixes aws#22566 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…and ECS (aws#22159) CloudFormation now supports Lambda and ECS in the `AWS::CodeDeploy::DeploymentConfig` resource type. This PR adds L2 constructs specific to ECS and Lambda for that resource type. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat(codedeploy): Add CodeDeploy deployment config constructs for Lam…

fc9178b

…bda and ECS

aws-cdk-automation requested a review from a team September 21, 2022 02:54

github-actions bot added the p2 label Sep 21, 2022

chore: deprecate codedeploy.CustomLambdaDeploymentConfig in favor of …

7b99479

…codedeploy.LambdaDeploymentConfig

clareliguori added 2 commits September 21, 2022 09:04

Merge pull request #3 from cplee/clareliguori/ecs-lambda-deployment-c…

9214223

…onfig chore: deprecate codedeploy.CustomLambdaDeploymentConfig

Merge branch 'main' into ecs-lambda-deployment-config

c1daa00

corymhall previously requested changes Sep 26, 2022

View reviewed changes

clareliguori added 2 commits September 26, 2022 10:24

Update traffic routing config to use an abstract class pattern

381ab47

Add docstrings

a91098c

Merge branch 'main' into ecs-lambda-deployment-config

86541b3

corymhall previously requested changes Sep 27, 2022

View reviewed changes

packages/@aws-cdk/aws-codedeploy/lib/traffic-routing-config.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-codedeploy/lib/ecs/deployment-config.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-codedeploy/lib/traffic-routing-config.ts Outdated Show resolved Hide resolved

clareliguori added 2 commits September 27, 2022 09:09

Fold in PR comments

a0405ce

Merge branch 'main' into ecs-lambda-deployment-config

3f9eb7f

corymhall previously requested changes Sep 27, 2022

View reviewed changes

packages/@aws-cdk/aws-codedeploy/lib/ecs/deployment-config.ts Outdated Show resolved Hide resolved

Move most deployment config logic into base class

af4252a

Merge branch 'main' into ecs-lambda-deployment-config

a3498f0

corymhall previously requested changes Sep 28, 2022

View reviewed changes

packages/@aws-cdk/aws-codedeploy/lib/base-deployment-config.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-codedeploy/lib/base-deployment-config.ts Outdated Show resolved Hide resolved

Move healthy hosts config to base class

313ecd3

corymhall previously requested changes Sep 29, 2022

View reviewed changes

packages/@aws-cdk/aws-codedeploy/lib/base-deployment-config.ts Outdated Show resolved Hide resolved

Fix comparison

62a2496

corymhall approved these changes Sep 29, 2022

View reviewed changes

Merge branch 'main' into ecs-lambda-deployment-config

a8112fb

mergify bot merged commit 6840d8e into aws:main Sep 29, 2022

clareliguori deleted the ecs-lambda-deployment-config branch September 29, 2022 15:33

clareliguori mentioned this pull request Sep 29, 2022

feat(codedeploy): CodeDeploy deployment group construct for ECS #22295

Merged

MrArnoldPalmer mentioned this pull request Oct 19, 2022

fix: breaking change to deployment config props #22567

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(codedeploy): CodeDeploy deployment config constructs for Lambda and ECS #22159

feat(codedeploy): CodeDeploy deployment config constructs for Lambda and ECS #22159

clareliguori commented Sep 21, 2022 •

edited

Loading

gitpod-io bot commented Sep 21, 2022

cplee commented Sep 21, 2022

clareliguori commented Sep 21, 2022

corymhall left a comment

clareliguori commented Sep 26, 2022

corymhall left a comment

corymhall left a comment

corymhall left a comment

mergify bot commented Sep 29, 2022

mergify bot commented Sep 29, 2022

aws-cdk-automation commented Sep 29, 2022

feat(codedeploy): CodeDeploy deployment config constructs for Lambda and ECS #22159

feat(codedeploy): CodeDeploy deployment config constructs for Lambda and ECS #22159

Conversation

clareliguori commented Sep 21, 2022 • edited Loading

All Submissions:

New Features

gitpod-io bot commented Sep 21, 2022

cplee commented Sep 21, 2022

clareliguori commented Sep 21, 2022

corymhall left a comment

Choose a reason for hiding this comment

clareliguori commented Sep 26, 2022

corymhall left a comment

Choose a reason for hiding this comment

corymhall left a comment

Choose a reason for hiding this comment

corymhall left a comment

Choose a reason for hiding this comment

mergify bot commented Sep 29, 2022

mergify bot commented Sep 29, 2022

aws-cdk-automation commented Sep 29, 2022

AWS CodeBuild CI Report

clareliguori commented Sep 21, 2022 •

edited

Loading