fix(ecs): removed explicit addition of ecs deployment type when circuit breaker is enabled #22328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
beginning-contributor
aws-cdk-automation
previously requested changes
Oct 3, 2022
There was a problem hiding this comment.
The Pull Request Linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.
PRs must pass status checks before we can provide a meaningful review.
fergusdixon
changed the title
aws-cdk-automation
dismissed
their stale review
Pull Request updated. Dissmissing previous PRLinter Review.
aws-cdk-automation
previously requested changes
Oct 3, 2022
mergify
bot
dismissed
aws-cdk-automation’s stale review
Pull request has been modified.
aws-cdk-automation
previously requested changes
Oct 4, 2022
fergusdixon
force-pushed
the
fix/remove-explicit-ecs-deployment-type-for-circuit-breaker
branch
from
261983c to
4a1eece
Compare
mergify
bot
dismissed
aws-cdk-automation’s stale review
Pull request has been modified.
aws-cdk-automation
previously requested changes
Oct 4, 2022
mergify
bot
dismissed
aws-cdk-automation’s stale review
Pull request has been modified.
corymhall
previously requested changes
Oct 5, 2022
| @@ -465,7 +463,9 @@ export abstract class BaseService extends Resource | |||
| if (props.deploymentController?.type === DeploymentControllerType.EXTERNAL) { | |||
| Annotations.of(this).addWarning('taskDefinition and launchType are blanked out when using external deployment controller.'); | |||
| } | |||
|
|
|||
| if (props.circuitBreaker && props.deploymentController?.type !== DeploymentControllerType.ECS) { | |||
| Annotations.of(this).addWarning('Deployment circuit breaker requires the ECS deployment controller.'); | |||
There was a problem hiding this comment.
This should be addError if it is not allowed.
mergify
bot
dismissed
corymhall’s stale review
Pull request has been modified.
fergusdixon
force-pushed
the
fix/remove-explicit-ecs-deployment-type-for-circuit-breaker
branch
2 times, most recently
from
47ffe21 to
a77de79
Compare
added 4 commits
October 7, 2022 10:43
fergusdixon
force-pushed
the
fix/remove-explicit-ecs-deployment-type-for-circuit-breaker
branch
from
a77de79 to
03beff6
Compare
corymhall
approved these changes
Oct 7, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
fergusdixon
deleted the
fix/remove-explicit-ecs-deployment-type-for-circuit-breaker
branch
|
Hi @fergusdixon + @corymhall - Could you please check my comment here: #16126 (comment) - Just to avoid issues or add needed clarification for existing stacks (while having a ServiceName defined). |
arewa
pushed a commit
to arewa/aws-cdk
that referenced
this pull request
Oct 8, 2022
…it breaker is enabled (aws#22328) Fixes aws#16126 Copied from aws#16919 with review comments as it went stale and closed. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
…hen circuit breaker is enabled (#22328)" (#22418) This reverts commit 635129c. Per comment #16126 (comment) this will introduce a breaking change. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
…feature flag) (#22467) Fixes #16126 Copied from #16919 with review comments as it went stale and closed. Initial implementation #22328 reverted because it was not backward compatible. Introduces feature flag: * `@aws-cdk/aws-ecs:disableExplicitDeploymentControllerForCircuitBreaker` Enable this feature flag to avoid setting the "ECS" deployment controller when adding a circuit breaker to an ECS Service, as this will trigger a full replacement which fails to deploy when using set service names. This does not change any behaviour as the default deployment controller when it is not defined is ECS. _cdk.json_ ```json { "context": { "@aws-cdk/aws-ecs:disableExplicitDeploymentControllerForCircuitBreaker": true } } ``` ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Dec 1, 2022
…it breaker is enabled (aws#22328) Fixes aws#16126 Copied from aws#16919 with review comments as it went stale and closed. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16126
Copied from #16919 with review comments as it went stale and closed.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license