Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix(ecs): removed explicit addition of ecs deployment type when circuit breaker is enabled (#22328)" #22418

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Conversation

corymhall
Copy link
Contributor

@corymhall corymhall commented Oct 7, 2022

This reverts commit 635129c.

Per comment #16126 (comment) this will introduce a breaking change.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…en circuit breaker is enabled (#22328)"

This reverts commit 635129c.
@gitpod-io
Copy link

gitpod-io bot commented Oct 7, 2022

@github-actions github-actions bot added the p2 label Oct 7, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team October 7, 2022 16:01
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 7, 2022
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2022

update

✅ Branch has been successfully updated

@corymhall corymhall changed the title Revert "fix(ecs): removed explicit addition of ecs deployment type when circuit breaker is enabled (#22328)" revert: "fix(ecs): removed explicit addition of ecs deployment type when circuit breaker is enabled (#22328)" Oct 7, 2022
@corymhall corymhall dismissed aws-cdk-automation’s stale review October 7, 2022 18:35

doesn't recognize revert.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e88fec3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0f002e2 into aws:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants