Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@aws-cdk/aws-redshift-alpha: Add encoding and comments for redshift tables column construct #22506

Closed
2 tasks
ksco92 opened this issue Oct 14, 2022 · 1 comment · Fixed by #23597 or #24177
Closed
2 tasks
Assignees
Labels
@aws-cdk/aws-redshift Related to Amazon Redshift effort/medium Medium work item – several days of effort feature/pfr Product Feature Requests that originated outside of GitHub feature-request A feature should be added or improved. p1

Comments

@ksco92
Copy link

ksco92 commented Oct 14, 2022

Describe the feature

Currently we have this construct:

https://docs.aws.amazon.com/cdk/api/v2/docs/@aws-cdk_aws-redshift-alpha.Table.html

Whose columns are defined as:

https://docs.aws.amazon.com/cdk/api/v2/docs/@aws-cdk_aws-redshift-alpha.Column.html

And this is great. However, in the world of big data, columns need encoding for faster performance and lower storage space:

https://docs.aws.amazon.com/redshift/latest/dg/c_Compression_encodings.html

Additionally, adding comments on columns allows us to be able document and version control our data definitions:

https://docs.aws.amazon.com/redshift/latest/dg/r_COMMENT.html

Use Case

The current table construct allows the programmatic creation and modification of columns, however, in real life, econdings for performance and storage and comments for documentation are critical in any big data use case.

This addition will bring CDK one step closer to being able to fully manage a Redshift's table table structure and documentation.

Proposed Solution

The idea, is that columns can be defined as:

{
  dataType: 'varchar(10)',
  name: 'my_col',
  distKey: false,
  sortKey: false,
  encoding: 'ZSTD',
  comment: 'some comment on column'
}

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.45

Environment details (OS name and version, etc.)

AmazonLinux2

@ksco92 ksco92 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 14, 2022
@github-actions github-actions bot added the @aws-cdk/aws-redshift Related to Amazon Redshift label Oct 14, 2022
@ksco92 ksco92 changed the title @aws-cdk/aws-redshift-alpha: Add encoding and comments for redshift tables construct @aws-cdk/aws-redshift-alpha: Add encoding and comments for redshift tables column construct Oct 28, 2022
@indrora indrora added p1 effort/medium Medium work item – several days of effort feature/pfr Product Feature Requests that originated outside of GitHub and removed needs-triage This issue or PR still needs to be triaged. labels Nov 16, 2022
@mergify mergify bot closed this as completed in #23597 Feb 10, 2023
mergify bot pushed a commit that referenced this issue Feb 10, 2023
…customised (#23597)

This feature request includes additions for compression encoding and comments for table columns. This feature request includes both features in one to close #22506

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mergify bot pushed a commit that referenced this issue Mar 8, 2023
…customised (#24177)

In accordance with #24165, I'm opening the same pull request as before. Not sure if my previous PR #23597 will automatically be "re-merged" in, but if not, then you can review this pull request

Will AGAIN close #22506

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk pushed a commit to homakk/aws-cdk that referenced this issue Mar 28, 2023
…customised (aws#24177)

In accordance with aws#24165, I'm opening the same pull request as before. Not sure if my previous PR aws#23597 will automatically be "re-merged" in, but if not, then you can review this pull request

Will AGAIN close aws#22506

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-redshift Related to Amazon Redshift effort/medium Medium work item – several days of effort feature/pfr Product Feature Requests that originated outside of GitHub feature-request A feature should be added or improved. p1
Projects
None yet
3 participants