-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-cdk: make "cdk notices" show only unacknowledged notices #23078
Comments
Thanks for this request, it would be nice if we supported this 🙂 I am marking this issue as p2, which means that we are unable to work on this immediately. We use +1s to help prioritize our work, and are happy to revaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization. Check out our contributing guide if you're interested in contributing yourself - there's a low chance the team will be able to address this soon but we'd be happy to review a PR 🙂 |
### Issue # (if applicable) Closes #23078 ### Reason for this change `cdk notices` will show all the notices the cdk version is affected by. The additional command `cdk notices --unacknowledged` will show the notices the customer hasn't acknowledge with `cdk acknowledge <NUMBER>`. The output will display the number of unacknowledged notices, with the following line as the last statement: `There are <NUMBER> unacknowledged notice(s).` Customer or automation tools can use this command to filter for the number of unacknowledged notices. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Comments on closed issues and PRs are hard for our team to see. |
### Issue # (if applicable) Closes aws#23078 ### Reason for this change `cdk notices` will show all the notices the cdk version is affected by. The additional command `cdk notices --unacknowledged` will show the notices the customer hasn't acknowledge with `cdk acknowledge <NUMBER>`. The output will display the number of unacknowledged notices, with the following line as the last statement: `There are <NUMBER> unacknowledged notice(s).` Customer or automation tools can use this command to filter for the number of unacknowledged notices. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes aws#23078 ### Reason for this change `cdk notices` will show all the notices the cdk version is affected by. The additional command `cdk notices --unacknowledged` will show the notices the customer hasn't acknowledge with `cdk acknowledge <NUMBER>`. The output will display the number of unacknowledged notices, with the following line as the last statement: `There are <NUMBER> unacknowledged notice(s).` Customer or automation tools can use this command to filter for the number of unacknowledged notices. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes #23078 ### Reason for this change `cdk notices` will show all the notices the cdk version is affected by. The additional command `cdk notices --unacknowledged` will show the notices the customer hasn't acknowledge with `cdk acknowledge <NUMBER>`. The output will display the number of unacknowledged notices, with the following line as the last statement: `There are <NUMBER> unacknowledged notice(s).` Customer or automation tools can use this command to filter for the number of unacknowledged notices. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the feature
Make it possible for
cdk notices
to show only the unacknowledged notices. Currently it lists "the notices that are relevant to the current CDK repository, regardless of context flags or notices that have been acknowledged" [link].Use Case
Checking if there are any unacknowledged notices in CI checks. Example
package.json
:Proposed Solution
One possible way to implement could be adding an
--unacknowledged-only
flag.Other Information
No response
Acknowledgements
CDK version used
2.50.0 (build 4c11af6)
Environment details (OS name and version, etc.)
macOS Monterey 12.6.1
The text was updated successfully, but these errors were encountered: