-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-autoscaling: Use launch templates instead of deprecated launch configurations #23165
Comments
Thanks for the request, this is something we should definitely have on our radar especially as the deprecation date nears at the end of next year |
More information on timelines from the email received:
This sounds like a fairly sizable change, but it would be nice if any functionality being deprecated could be replaced with the launch template equivalent before the respective date of deprecation. One use case in particular is providing user commands with |
@peterwoodworth Any update on this? Our team also received an email notification about the launch configuration deprecation. However, we are having a hard time migrating because the |
@peterwoodworth Any progress on this? We are nearing the second key date and there hasn't been any progress on the issue. What can we do to help? |
We have the same problem - not able to migrate to launch templates because it is not possible to attach CloudFormationInit to LaunchTemlpate. |
We just received a reminder deprecation notice. I would love to hear an official voice. Best, |
Hi everyone. I wanted to comment to say that this is in progress and is currently being worked on. |
@mbp @simonrouse9461 @kvndng-amz I've been looking into the CloudFormationInit and LaunchTemplate issues and from what I can tell, it looks like the way to do this would be to not add the CloudFormationInit to the LaunchTemplate and instead to continue adding a CloudFormationInit as part of the AutoScalingGroup similar to if you wanted to use a CloudFormationInit with a launch configuration. Have any of you attempted this with success? I want to verify that I'm not overlooking something. |
Sorry for late response. I tried with the following code:
As you can see - I pass But it provides the following error: Because of this error - I tried to move cloudformation init to LaunchTemplate (without success). |
Hi any update on this? Currently AutoScalingGroup with CDK is still using Launch Config instead of Launch template? At least could you point me to usage for configuring my own Launch Template? |
@abalasky-chronos I'm close to having a PR ready for review. I have the code done and am just working on getting 6 or so integ tests updated. I should have a PR in soon. In the meantime, this mapping may be able to help you configure an equivalent launch template based on launch configuration properties - https://docs.aws.amazon.com/autoscaling/ec2/userguide/migrate-launch-configurations-with-cloudformation.html#launch-configuration-mapping-reference. |
@mbp no worries and thanks for your response. I think the issue here is that if no explicit user data is provided with the launch template, then when we try to get the user data to pass to the cfn-init configuration method when creating the auto scaling group an error is thrown since user data would be undefined. We added a feature flag to configure a launch template with default user data based on the provided machine image though. If that is set to true that error should go away. That said, I'm working on addressing this in the launch configuration deprecation since I can see how this would cause confusion. |
@colifran Thank you so much! Appreciate the prompt response. |
Slightly tangential to this issue, but the (python) docs suggest this is already supported, but actually the Example output trying to use
|
@SamuelLordMO this seems like it would be a separate issue. The deprecation of launch configurations will result in the auto scaling group automatically generating a launch template from properties that were previously used to create a launch configuration. So, your new options will be provide a launch template, provide a mixed instances policy, or provide properties that will be used to automatically generate a launch template for you. Providing an explicit launch template is already supported, so this could be a bug. Could you provide a snippet of the code you're using so that we could try to reproduce the issue on our end? |
In putting together a minimal repro I found that my issue was actually an old venv that was out of date being used for synth, but not for docs/autocomplete etc. So I won't raise a bug! Thanks for your quick response, though :) |
…g) (#25910) This PR focuses on supporting the deprecation of launch configurations when creating an auto scaling group. All new accounts created after December 31, 2023 will no longer be able to create launch configurations. An equivalent launch template will now be created by the AutoScalingGroup construct instead of a launch configuration. Closes #23165 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
…g) (aws#25910) This PR focuses on supporting the deprecation of launch configurations when creating an auto scaling group. All new accounts created after December 31, 2023 will no longer be able to create launch configurations. An equivalent launch template will now be created by the AutoScalingGroup construct instead of a launch configuration. Closes aws#23165 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…g) (aws#25910) This PR focuses on supporting the deprecation of launch configurations when creating an auto scaling group. All new accounts created after December 31, 2023 will no longer be able to create launch configurations. An equivalent launch template will now be created by the AutoScalingGroup construct instead of a launch configuration. Closes aws#23165 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Hi am facing same issue, can you please help me with your hack?? |
Describe the feature
We just got an email from AWS saying launch configurations are deprecated. New accounts won't allow creating launch configurations after December 31st, 2023. No new features or instance types will be available after December 31st, 2022.
Unless given a launch template, AutoScalingGroup always creates a deprecated launch configuration.
Use Case
Deploying existing CDK apps that use AutoScalingGroup without manually specifying a manually created launch template would fail soon. Using new instance types will be impossible without first manually creating a launch template.
Proposed Solution
It would be great if AutoScalingGroup could start creating launch templates instead of launch configurations.
Other Information
No response
Acknowledgements
CDK version used
2.52.0
Environment details (OS name and version, etc.)
N/A
The text was updated successfully, but these errors were encountered: