(route53): PrivateHostedZone fromPrivateHostedZoneAttributes function with zoneName support

[aamielsan]

Describe the feature

Same as the PublicHostedZone.fromPublicHostedZoneAttributes we would like to resolve an IPrivateHostedZone from a zone ID and zone name.

Currently, we can import a private hosted zone using PrivateHostedZone.fromPrivateHostedZoneId, but this will not allow us to reference the zoneName in CDK which is needed for our use case.

Use Case

We have a use case where we're creating record sets using CfnRecordSet for an imported private hosted zone. We created a custom construct that takes a IPrivateHostedZone as a parameter, and we need the zone name to create the full subdomain name in the custom construct. We could use IHostedZone but would like to be strict and only have the custom construct to accept IPrivateHostedZone

Proposed Solution

Use the same implementation for PublicHostedZone.fromPublicHostedZoneAttributes

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

CDK version used

2.47.0

Environment details (OS name and version, etc.)

MacOS Monterey

[peterwoodworth]

It says this in our docs:

aws-cdk/packages/@aws-cdk/aws-route53/lib/hosted-zone.ts

Line 386 in 7690f43

* If the zoneName is needed then you cannot import a PrivateHostedZone.

Though, I cannot remember if there is a reason we cannot support this, or if this line was added because we just currently do not support it. I don't see what would be limiting us from being able to supply the zoneName here, so I would think this is a valid feature request. Thanks for the submission 🙂

I am marking this issue as p2, which means that we are unable to work on this immediately.

We use +1s to help prioritize our work, and are happy to revaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

Check out our contributing guide if you're interested in contributing yourself - there's a low chance the team will be able to address this soon but we can try to review a PR

[aamielsan]

I would really love to raise a PR for this and have this as my first contribution to CDK 😄