fix(rds): add clusterResourceIdentifier property to database cluster #23605
Conversation
|
|
github-actions
bot
added
beginning-contributor
alexedwardjones
changed the title
alexedwardjones
changed the title
alexedwardjones
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
|
@TheRealAmazonKendra @rix0rrr Any chance of a review on this? |
There was a problem hiding this comment.
do we need to expose this identifier? It seems to just be a component of the arn, eg
arn:aws:rds-db:region:account-id:dbuser:DbClusterResourceId/db-user-name
If the only goal is to refer to the cluster in IAM policies, the arn being exposed should be sufficient here, since the DbClusterResourceId is only used to construct the ARN. If we absolutely must use this DbClusterResourceId, can we hide that complexity behind somegrant*() methods.
| /** | ||
| * The immutable identifier for the cluster; for example: cluster-ABCD1234EFGH5678IJKL90MNOP. | ||
| * | ||
| * This AWS Region-unique identifier is used in things like IAM authentication policies. |
There was a problem hiding this comment.
| * This AWS Region-unique identifier is used in things like IAM authentication policies. | |
| * This AWS Region-unique identifier is used to grant access to the cluster. | |
| * | |
| * @see https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/UsingWithRDS.IAMDBAuth.IAMPolicy.html |
mergify
bot
dismissed
comcalvi’s stale review
Pull request has been modified.
| * | ||
| * This AWS Region-unique identifier is used in things like IAM authentication policies. | ||
| * | ||
| * @default - none |
There was a problem hiding this comment.
| * @default - none | |
| * @default none |
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…ws#23605) **Summary** - Exposed the [`DBClusterResourceId`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbcluster.html#aws-resource-rds-dbcluster-return-values) on the database cluster as `clusterResourceIdentifier`. - This is needed to [create an IAM policy for IAM database access](https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/UsingWithRDS.IAMDBAuth.IAMPolicy.html).
Summary
DBClusterResourceIdon the database cluster asclusterResourceIdentifier.