-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rds): add clusterResourceIdentifier property to database cluster #23605
Merged
mergify
merged 19 commits into
aws:main
from
alexedwardjones:refactor/add-cluster-resource-id-to-database-cluster
Mar 6, 2023
Merged
Changes from 15 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8fa21f8
refactor(aws-rds): add clusterResourceIdentifier property to database…
alexedwardjones 655bc19
chore(cluster-ref.ts): remove trailing spaces
alexedwardjones ab9af6e
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
alexedwardjones b046f87
chore(cluster-ref.ts): update docs
alexedwardjones 7e147a5
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
alexedwardjones 61f61bf
test(integ.cluster.ts): add iam auth policy to cluster snapshot
alexedwardjones 9196dc5
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
alexedwardjones 4370503
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
alexedwardjones 9e4252e
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
alexedwardjones e0012a3
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
alexedwardjones db4ca64
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
alexedwardjones a6a30a7
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
alexedwardjones ce6fc33
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
alexedwardjones 847c8e7
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
alexedwardjones a9b5efc
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
alexedwardjones 9628487
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
alexedwardjones e4d87e4
chore(cluster-ref.ts): comment changes from pr feedback
alexedwardjones d4b57df
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
alexedwardjones 0981e65
Merge branch 'main' into refactor/add-cluster-resource-id-to-database…
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -14,6 +14,13 @@ export interface IDatabaseCluster extends IResource, ec2.IConnectable, secretsma | |||||
*/ | ||||||
readonly clusterIdentifier: string; | ||||||
|
||||||
/** | ||||||
* The immutable identifier for the cluster; for example: cluster-ABCD1234EFGH5678IJKL90MNOP. | ||||||
* | ||||||
* This AWS Region-unique identifier is used in things like IAM authentication policies. | ||||||
*/ | ||||||
readonly clusterResourceIdentifier: string; | ||||||
|
||||||
/** | ||||||
* Identifiers of the replicas | ||||||
*/ | ||||||
|
@@ -57,6 +64,15 @@ export interface DatabaseClusterAttributes { | |||||
*/ | ||||||
readonly clusterIdentifier: string; | ||||||
|
||||||
/** | ||||||
* The immutable identifier for the cluster; for example: cluster-ABCD1234EFGH5678IJKL90MNOP. | ||||||
* | ||||||
* This AWS Region-unique identifier is used in things like IAM authentication policies. | ||||||
* | ||||||
* @default - none | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
*/ | ||||||
readonly clusterResourceIdentifier?: string; | ||||||
|
||||||
/** | ||||||
* The database port | ||||||
* | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
packages/@aws-cdk/aws-rds/test/integ.cluster.js.snapshot/aws-cdk-rds-integ.assets.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/@aws-cdk/aws-rds/test/integ.cluster.js.snapshot/cdk.out
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
{"version":"20.0.0"} | ||
{"version":"29.0.0"} |
2 changes: 1 addition & 1 deletion
2
packages/@aws-cdk/aws-rds/test/integ.cluster.js.snapshot/integ.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"version": "20.0.0", | ||
"version": "29.0.0", | ||
"testCases": { | ||
"integ.cluster": { | ||
"stacks": [ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @comcalvi, thanks for the review 😄
I was following the existing examples of docdb and neptune that expose both the cluster identifier and cluster resource identifiers as properties.