Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(synthetics): add DeleteLambdaResourcesOnCanaryDeletion to the canary L2 #23772

Closed
1 of 2 tasks
kaizencc opened this issue Jan 20, 2023 · 4 comments · Fixed by #23820
Closed
1 of 2 tasks

(synthetics): add DeleteLambdaResourcesOnCanaryDeletion to the canary L2 #23772

kaizencc opened this issue Jan 20, 2023 · 4 comments · Fixed by #23820
Assignees
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@kaizencc
Copy link
Contributor

Describe the feature

Lambda has a new? property that will delete lambda resources when the canary is deleted.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-synthetics-canary.html#cfn-synthetics-canary-deletelambdaresourcesoncanarydeletion

This is a step in the right direction, but still not perfect, because canaries will still isolate s3 buckets, log groups, etc. Still, we should support this property in the L2 and allow our users to specify this prop.

Use Case

Currently, after deleting the canary you have to go and manually delete lambda/s3/cloudwatch logs. Now, you can set this property and only delete s3 + cloudwatch.

Proposed Solution

Add the prop to Canary. This will need some testing to make sure that the property is doing what we expect.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

latest

Environment details (OS name and version, etc.)

MacOs

@kaizencc kaizencc added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 20, 2023
@SankyRed SankyRed self-assigned this Jan 20, 2023
@mergify mergify bot closed this as completed in #23820 Jan 29, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@jedwards1211
Copy link

Did this property go away? OP's link to the CloudFormation docs no longer shows anything about DeleteLambdaResourcesOnCanaryDeletion.

@SankyRed
Copy link
Contributor

SankyRed commented Jun 3, 2024

As part of stabilizing the synthetics module I see @kaizencc has cleaned up DeleteLambdaResourcesOnCanaryDeletion property in this PR. Also, instead of enableAutoDeleteLambdas you could use cleanup: Cleanup.LAMBDA the same affect via custom resource.

@jedwards1211
Copy link

Do you know if CloudFormation itself supports deleting the lambda? I'm not actually using the CDK, just landed here because OP had a link to the CloudFormation docs that looks like it mentioned the kind of option I need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants