Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(synthetics): Adding DeleteLambdaResourcesOnCanaryDeletion prop to the canary L2 #23820

Merged
merged 6 commits into from
Jan 29, 2023
Merged

feat(synthetics): Adding DeleteLambdaResourcesOnCanaryDeletion prop to the canary L2 #23820

merged 6 commits into from
Jan 29, 2023

Conversation

SankyRed
Copy link
Contributor

@SankyRed SankyRed commented Jan 24, 2023 •
edited
Loading

This PR is to add the DeleteLambdaResourcesOnCanaryDeletion prop to the canary L2.

@gitpod-io
Copy link

gitpod-io bot commented Jan 24, 2023

@github-actions github-actions bot added the p2 label Jan 24, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team January 24, 2023 22:32
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 24, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

comcalvi
comcalvi requested changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This is pretty close to being merged

packages/@aws-cdk/aws-synthetics/lib/runtime.ts Show resolved Hide resolved
packages/@aws-cdk/aws-synthetics/lib/runtime.ts Show resolved Hide resolved
packages/@aws-cdk/aws-synthetics/test/canary.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-synthetics/lib/canary.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 25, 2023 17:20

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@SankyRed SankyRed linked an issue Jan 27, 2023 that may be closed by this pull request
(synthetics): add DeleteLambdaResourcesOnCanaryDeletion to the canary L2 #23772
Closed
2 tasks
@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b157557
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 45c191e into main Jan 29, 2023
@mergify mergify bot deleted the SankyRed/addCanaryResource branch January 29, 2023 07:37
@mergify
Copy link
Contributor

mergify bot commented Jan 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comcalvi comcalvi comcalvi approved these changes

@kaizencc kaizencc Awaiting requested review from kaizencc

@aws-cdk-automation aws-cdk-automation Awaiting requested review from aws-cdk-automation

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(synthetics): add DeleteLambdaResourcesOnCanaryDeletion to the canary L2
4 participants
@SankyRed @aws-cdk-automation @kaizencc @comcalvi