feat(redshift): column compression encodings and comments can now be customised

[Rizxcviii]

In accordance with #24165, I'm opening the same pull request as before. Not sure if my previous PR #23597 will automatically be "re-merged" in, but if not, then you can review this pull request

Will AGAIN close #22506

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

Pull request has been modified.

[Rizxcviii]

The tests failed with

RuntimeError: Cannot find module 'aws-sdk/clients/redshiftdata'

It's consistently failed, but I'm not sure why. I won't be available next week, but I'll run it through again when I get back.

full trace:

jsii.errors.JavaScriptError:
--
Error: Cannot find module 'aws-sdk/clients/redshiftdata'
Require stack:
- /tmp/jsii-kernel-5stNJk/node_modules/@aws-cdk/aws-redshift-alpha/lib/private/database-query-provider/redshift-data.js
- /tmp/jsii-kernel-5stNJk/node_modules/@aws-cdk/aws-redshift-alpha/lib/private/database-query-provider/privileges.js
- /tmp/jsii-kernel-5stNJk/node_modules/@aws-cdk/aws-redshift-alpha/lib/private/database-query-provider/index.js
- /tmp/jsii-kernel-5stNJk/node_modules/@aws-cdk/aws-redshift-alpha/lib/table.js
- /tmp/jsii-kernel-5stNJk/node_modules/@aws-cdk/aws-redshift-alpha/lib/index.js
- /tmp/jsii-kernel-5stNJk
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
at Function.Module._load (internal/modules/cjs/loader.js:746:27)
at Module.require (internal/modules/cjs/loader.js:974:19)
at require (internal/modules/cjs/helpers.js:101:18)
at Object.<anonymous> (/tmp/jsii-kernel-5stNJk/node_modules/@aws-cdk/aws-redshift-alpha/lib/private/database-query-provider/redshift-data.js:5:22)
at Module._compile (internal/modules/cjs/loader.js:1085:14)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
at Module.load (internal/modules/cjs/loader.js:950:32)
at Function.Module._load (internal/modules/cjs/loader.js:790:12)
at Module.require (internal/modules/cjs/loader.js:974:19)

Not sure if this is the reason, but when I'm working on other features, I'm being told to upgrade to SDK version 3? Perhaps the SDK version 3 is installed on the test pipeline, but not SDK version 2?

[TheRealAmazonKendra]

We are not yet on SDK v3 due to other dependency limitations. If this module is only available in v3, cannot accept this change at this time.

[TheRealAmazonKendra]

This could also be a result of our lambda layers being behind in v2 as well. We've now addressed that piece so we'll want to run this through our testing pipeline again to see what the outcome is.

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[Rizxcviii]

@comcalvi is there any update with this PR?

[comcalvi]

I ran it through the pipeline earlier this week, but it failed again. I'm running it again right now to see if it's the same failures

[comcalvi]

same error as before...going to investigate this today

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 2613835
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[comcalvi]

That fixed it, thanks for reopening this PR

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).