Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-logs): update log retention lambdas to nodejs18.x #24202

Closed
2 tasks
wilhen01 opened this issue Feb 16, 2023 · 5 comments
Closed
2 tasks

(aws-logs): update log retention lambdas to nodejs18.x #24202

wilhen01 opened this issue Feb 16, 2023 · 5 comments
Labels
@aws-cdk/aws-logs Related to Amazon CloudWatch Logs duplicate This issue is a duplicate. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@wilhen01
Copy link
Contributor

Describe the feature

Similar to #23682, Lambdas created via Log Retention settings are currently using the Node 14 runtime. Node 14 is EOL at the end of April, just over two months away. These lambdas should be updated to Node 18 prior to that EOL.

Use Case

All lambdas created by aws-cdk internally should be updated prior to EOL.

Proposed Solution

Update to NODEJS_18_X when creating lambda in aws-logs.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.63.0

Environment details (OS name and version, etc.)

Mac OS
@wilhen01 wilhen01 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 16, 2023
@github-actions github-actions bot added the @aws-cdk/aws-logs Related to Amazon CloudWatch Logs label Feb 16, 2023
@pahud pahud added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 16, 2023
@pahud
Copy link
Contributor

pahud commented Feb 16, 2023

Yes we should get it fixed. Are you interested to submit a PR for that?

@pahud pahud added the effort/small Small work item – less than a day of effort label Feb 16, 2023
@wilhen01
Copy link
Contributor Author

@pahud I can try and find time for this, sure 😊

@wilhen01 wilhen01 mentioned this issue Feb 16, 2023
Closed
@wilhen01
Copy link
Contributor Author

@pahud I've raised #24203 to cover this. Hopefully all correct 😄

@abelmokadem abelmokadem mentioned this issue Apr 5, 2023
Closed
2 tasks
@peterwoodworth peterwoodworth added the duplicate This issue is a duplicate. label Apr 12, 2023
@peterwoodworth
Copy link
Contributor

We only need to track this on one issue #23682

@peterwoodworth peterwoodworth closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-logs Related to Amazon CloudWatch Logs duplicate This issue is a duplicate. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(logs): update log retention lambda runtime to Node 18
3 participants
@pahud @wilhen01 @peterwoodworth