(custom-resources): use lambda.Runtime.NODEJS_18_X by default in Provider

[twulf]

Describe the feature

Similar to #19117 we should update to latest supported Node.js runtime for the custom-resources lambda prior to Node 14 going out of service.

aws-cdk/packages/@aws-cdk/custom-resources/lib/provider-framework/provider.ts

Line 210 in 2d40d77

runtime: lambda.Runtime.NODEJS_14_X,

Use Case

All lambdas created by aws-cdk internally should be updated prior to EOL.

Proposed Solution

Update to NODEJS_18_X when creating lambda in custom-resources.

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

CDK version used

2.60.0

Environment details (OS name and version, etc.)

MacOS 12.6.2

[wilhen01]

+1 for this. Node 14 EOL is now rapidly approaching!

[pahud]

Node18 has been supported in GovCloud and AWS China regions as well. I believe we can create a PR for this now.

[cornelcroi]

Hi,

Any updates on this?
I have an application impossible to deploy now.
Any workaround possible?
Thanks.

[kaizencc]

@cornelcroi we are working to move to Node 18 but your application should not be impossible to deploy. If you are seeing errors related to Node 12, then you need to update your aws-cdk-lib version. aws-cdk-lib exclusively uses Node 14+ currently.

[anoppe]

It might not be the most elegant solution, but If you don't want to be blocked by CDK lib releases, you could also use an aspect to change the runtime of the lambda created by, for example, the provider framework.
A naive example, written in Java:

// Change the provider framework lambda runtime to node18.
Aspects.of(this).add(node -> {
    if (node instanceof CfnFunction) {
        if (((CfnFunction) node).getRuntime().startsWith("node")
                && !((CfnFunction) node).getRuntime().equals("nodejs18.x")) {
            ((CfnFunction) node).setRuntime("nodejs18.x");
        }
    }
});

[peterwoodworth]

We did this, but we have missed some. Closing this in favor of the bug report that's more up to date #26461

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.