Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(custom-resources): use lambda.Runtime.NODEJS_14_X by default in Provider #19117

Closed
1 of 2 tasks
pkwarren opened this issue Feb 23, 2022 · 10 comments
Closed
1 of 2 tasks
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@pkwarren
Copy link

Description

Similar to #13225, we should update to latest supported Node.js runtime for the custom-resources lambda prior to Node 12 going out of service.

Use Case

All lambdas created by aws-cdk internally should be updated prior to EOL.

Proposed Solution

Update to NODEJS_14_X when creating lambda in custom-resources.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@pkwarren pkwarren added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 23, 2022
@github-actions github-actions bot added the @aws-cdk/custom-resources Related to AWS CDK Custom Resources label Feb 23, 2022
@rix0rrr
Copy link
Contributor

rix0rrr commented Feb 24, 2022

Can you share or link the communication you've gotten from Lambda? I can't seem to find any easily.

@rix0rrr rix0rrr added effort/medium Medium work item – several days of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 24, 2022
@rix0rrr rix0rrr removed their assignment Feb 24, 2022
@pkwarren
Copy link
Author

pkwarren commented Feb 24, 2022

We've not gotten communication from AWS Lambda yet but we're in the process of updating all of our existing CDK projects because of Node 10.x no longer being supported: https://docs.aws.amazon.com/lambda/latest/dg/runtime-support-policy.html

Since Node 12.x is no longer receiving security updates this spring (https://nodejs.org/en/about/releases/) it felt like a good preventative change to keep ahead of these and use the latest supported Node runtime.

@JeeZeh
Copy link

JeeZeh commented Aug 16, 2022

We've not gotten communication from AWS Lambda yet

This week we've received the following guidance from AWS. We have a few custom resources defined in our accounts, which specify non-Node Lambda event handlers, but it seems the CustomResource Provider sets up a NodeJS 12 Lambda itself (description: AWS CDK resource provider framework).

I'm assuming this issue, once resolved, will upgrade the runtime of these providers.

Thanks,
Jesse


Hello,

We are contacting you as we have identified that your AWS Account currently has one or more Lambda functions using Node.js 12 runtime.

We are ending support for Node.js 12 in AWS Lambda. This follows Node.js 12 End-Of-Life (EOL) reached on April 30, 2022 [1].

As described in the Lambda runtime support policy [2], end of support for language runtimes in Lambda happens in two stages. Starting November 14, 2022, Lambda will no longer apply security patches and other updates to the Node.js 12 runtime used by Lambda functions, and functions using Node.js 12 will no longer be eligible for technical support. In addition, you will no longer be able to create new Lambda functions using the Node.js 12 runtime. Starting December 14, 2022, you will no longer be able to update existing functions using the Node.js 12 runtime.

We recommend that you upgrade your existing Node.js 12 functions to Node.js 16 before November 14, 2022.

@TakahiroImanishi
Copy link

Hi.

I think this problem is solved by #20297 .
I also checked the implementation.

#20297

@JeeZeh
Copy link

JeeZeh commented Aug 17, 2022

Hi.

I think this problem is solved by #20297 .
I also checked the implementation.

#20297

Unless I misunderstand, this only resolves the issue for a Route 53 construct which uses custom resources right? The proposed change here is to set it as the default runtime for the custom resource framework itself.

@TakahiroImanishi
Copy link

Thank you.
I understand #20297 is for a Route53 constrcut.

But,I read a source code, the code is fixed now.

@TakahiroImanishi
Copy link

Sorry, I may be misunderstanding the FIX Issue.
I don't read past issues.
Whichever, I think it is fixes this issue now.

@keisukekomeda
Copy link

keisukekomeda commented Aug 17, 2022

Provider-framework lambda functions which were created before the PR #20595 seem to remain Node.js 12.x, even if the stacks including custom resources are redeployed.
It might be confusing for you and others.

If there's a way to update the existing provider-framework lambda function, it helps.

@peterwoodworth
Copy link
Contributor

This has been fixed, live code shows node 14

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

No branches or pull requests

6 participants