Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(route53): Use lambda.Runtime.NODEJS_14_X in CrossAccountZoneDelegationRecord #20297

Closed
1 of 2 tasks
psoares-resilient opened this issue May 11, 2022 · 2 comments
Closed
1 of 2 tasks
Assignees
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@psoares-resilient
Copy link

psoares-resilient commented May 11, 2022

Describe the feature

It currently uses a custom cloudformation resource which is a lambda running on NODEJS_12_X

Use Case

Make sure we are using the latest available node for that purpose

Proposed Solution

Single config change in CrossAccountZoneDelegationRecord inside route53 package:

const provider = CustomResourceProvider.getOrCreateProvider(this, CROSS_ACCOUNT_ZONE_DELEGATION_RESOURCE_TYPE, {
      codeDirectory: path.join(__dirname, 'cross-account-zone-delegation-handler'),
      runtime: CustomResourceProviderRuntime.NODEJS_14_X,
    });

Other Information

Maybe related to this issue: #19117

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.23.0

Environment details (OS name and version, etc.)

macOs

@psoares-resilient psoares-resilient added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 11, 2022
@github-actions github-actions bot added the @aws-cdk/aws-route53 Related to Amazon Route 53 label May 11, 2022
@comcalvi
Copy link
Contributor

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants