Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(route53): update nodejs runtime on custom resource for cross account zone delegation #20298

Closed
wants to merge 1 commit into from

Conversation

psoares-resilient
Copy link


PR that relates to #20297

All Submissions:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 11, 2022

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 3a85185
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@TheRealAmazonKendra TheRealAmazonKendra changed the base branch from v1-main to main June 2, 2022 18:24
@psoares-resilient
Copy link
Author

After reading in another PR, I'm closing it knowing that:

  1. not all regions had node14 available and
  2. The construct in question creates a new request on every deploy (even if nothing has changed on the stack itself).
  3. CertificateManager has a similar construct that we extended to Request (with removal retain policy) Or Import if cert exists (async deploy checks at synth time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants