Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(eks): (helm flag --skip-crds) #24296

Closed
1 of 2 tasks
alexandersperling opened this issue Feb 23, 2023 · 2 comments · Fixed by #24213 · May be fixed by WontonSam/apollo-federation-subgraph-compatibility#508, WontonSam/apollo-federation-subgraph-compatibility#511 or WontonSam/apollo-federation-subgraph-compatibility#523
Closed
1 of 2 tasks

(eks): (helm flag --skip-crds) #24296

alexandersperling opened this issue Feb 23, 2023 · 2 comments · Fixed by #24213 · May be fixed by WontonSam/apollo-federation-subgraph-compatibility#508, WontonSam/apollo-federation-subgraph-compatibility#511 or WontonSam/apollo-federation-subgraph-compatibility#523
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@alexandersperling
Copy link
Contributor

Describe the feature

Helm provides the feature flag to skip the installation of custom resource definitions.

This flag could be added to the helm chart construct.

Use Case

When installing Helm chart sometimes it is needed to skip the installation of custom resource definitions. (e.g. when you are managing those crds by yourself)

Proposed Solution

Adding the flag --skip-crds to the Helmchart Construct could

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2

Environment details (OS name and version, etc.)

Mac OS 13.2
@alexandersperling alexandersperling added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 23, 2023
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Feb 23, 2023
@alexandersperling alexandersperling mentioned this issue Feb 23, 2023
Merged
@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 23, 2023
@pahud
Copy link
Contributor

pahud commented Feb 23, 2023

Thank you for the PR contribution!

@mergify mergify bot closed this as completed in #24213 Feb 27, 2023
mergify bot pushed a commit that referenced this issue Feb 27, 2023
@alexandersperling
feat(eks): add helm flag --skip-crds (#24213)
f68dbc2 
When installing Helm chart sometimes it is needed to skip the installation of custom resource definitions.
This MR adds the functionality to the helm chart construct.

In fact I did the following

* Add the possibility to skip the installation of crds in a helm chart via a new property
* Add tests for skipCrds property
* Update README

Closes #24296 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

westhouseK pushed a commit to westhouseK/aws-cdk that referenced this issue Feb 28, 2023
@alexandersperling @westhouseK
feat(eks): add helm flag --skip-crds (aws#24213)
700c0ef 
When installing Helm chart sometimes it is needed to skip the installation of custom resource definitions.
This MR adds the functionality to the helm chart construct.

In fact I did the following

* Add the possibility to skip the installation of crds in a helm chart via a new property
* Add tests for skipCrds property
* Update README

Closes aws#24296 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
beck3905 pushed a commit to beck3905/aws-cdk that referenced this issue Feb 28, 2023
@alexandersperling @beck3905
feat(eks): add helm flag --skip-crds (aws#24213)
739793d 
When installing Helm chart sometimes it is needed to skip the installation of custom resource definitions.
This MR adds the functionality to the helm chart construct.

In fact I did the following

* Add the possibility to skip the installation of crds in a helm chart via a new property
* Add tests for skipCrds property
* Update README

Closes aws#24296 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk pushed a commit to homakk/aws-cdk that referenced this issue Mar 28, 2023
@alexandersperling @homakk
feat(eks): add helm flag --skip-crds (aws#24213)
b8de9d9 
When installing Helm chart sometimes it is needed to skip the installation of custom resource definitions.
This MR adds the functionality to the helm chart construct.

In fact I did the following

* Add the possibility to skip the installation of crds in a helm chart via a new property
* Add tests for skipCrds property
* Update README

Closes aws#24296 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Sep 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@pahud @alexandersperling