Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awslint:props-no-unions #2430

Closed
eladb opened this issue May 1, 2019 · 0 comments · Fixed by #2509
Closed

awslint:props-no-unions #2430

eladb opened this issue May 1, 2019 · 0 comments · Fixed by #2509
Labels
package/awscl Cross-cutting issues related to the AWS Construct Library

Comments

@eladb
Copy link
Contributor

eladb commented May 1, 2019 •
edited
Loading

Props should not use TypeScript unions
@eladb eladb added the package/awscl Cross-cutting issues related to the AWS Construct Library label May 1, 2019
@eladb eladb changed the title awslint:props-no-unions: Props should not use TypeScript unions awslint:props-no-unions May 1, 2019
@shivlaks shivlaks self-assigned this May 7, 2019
shivlaks added a commit that referenced this issue May 8, 2019
@shivlaks
refactor: L2 constructs should not use TypeScript unions (awslint:pro…
29f3240 
…ps-no-unions) (#2430)

Adds a new awslint:props-no-unions rule which valides that props for L2 constructs do not use TypeScript unions. This is in accordance with the new AWS Construct Library guidelines.
shivlaks added a commit that referenced this issue May 8, 2019
@shivlaks
refactor: L2 constructs should not use TypeScript unions (awslint:pro…
cf610ca 
…ps-no-unions) (#2430)

Adds a new awslint:props-no-unions rule which valides that props for L2 constructs do not use TypeScript unions. This is in accordance with the new AWS Construct Library guidelines.
@shivlaks shivlaks mentioned this issue May 9, 2019
Merged
4 tasks
shivlaks added a commit that referenced this issue May 13, 2019
@shivlaks
refactor: L2 constructs should not use TypeScript unions (awslint:pro…
7863ad3 
…ps-no-unions) (#2430) (#2509)

Adds a new awslint:props-no-unions rule which valides that props for L2 constructs do not use TypeScript unions. This is in accordance with the new AWS Construct Library guidelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package/awscl Cross-cutting issues related to the AWS Construct Library
Projects
None yet
Milestone
No milestone
2 participants
@eladb @shivlaks