Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EbsDeviceProps missing support for setting throughput on GP3 volumes, yet VolumeProps has support for it #24341

Closed
2 tasks
adrabkin opened this issue Feb 26, 2023 · 4 comments · Fixed by #30716 · May be fixed by mannjaro/serverless-bedrock-proxy#4
Closed
2 tasks

EbsDeviceProps missing support for setting throughput on GP3 volumes, yet VolumeProps has support for it #24341

adrabkin opened this issue Feb 26, 2023 · 4 comments · Fixed by #30716 · May be fixed by mannjaro/serverless-bedrock-proxy#4
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@adrabkin
Copy link

Describe the feature

When creating and EC2 instance, and configuring a blockDevices property, this uses the BlockDeviceVolume type, which accepts an ebsDevice parameter of type EbsDeviceProps. EbsDeviceProps does not have the option to set a throughput property.

However, if you look at VolumeProps, when creating a volume separately, it does support the throughput property.

Use Case

I've seen examples where people are creating volumes outside of the blockDevices property of an Instance, then have to deal with attaching the volume.

Having the option to create a gp3 volume along with all of its configuration properties (including throughput) directly via the instance as part of the blockDevices property simplifies the deployment of an instance. iops is already an accepted property as part of EbsDeviceProps, why not throughput?

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.66.1

Environment details (OS name and version, etc.)

OSX 12.6.3
@adrabkin adrabkin added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 26, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Feb 26, 2023
@pahud
Copy link
Contributor

pahud commented Mar 1, 2023

Yes we probably should add this property in EbsDeviceOptionsBase or other interfaces. I'm making this a p2 feature request and any PR submission will be more than welcome and appreciated.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 1, 2023
isker added a commit to isker/aws-cdk that referenced this issue May 23, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
6dde01b 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly and adapted its tests.

Fixes aws#24341.
@isker isker mentioned this issue May 23, 2024
Closed
1 task
isker added a commit to isker/aws-cdk that referenced this issue May 23, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
e1d73f1 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
isker added a commit to isker/aws-cdk that referenced this issue Jun 16, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
de81e35 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
isker added a commit to isker/aws-cdk that referenced this issue Jun 18, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
672fd0d 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
isker added a commit to isker/aws-cdk that referenced this issue Jul 1, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
dec6ea0 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
@isker isker mentioned this issue Jul 1, 2024
Merged
1 task
@isker
Copy link
Contributor

isker commented Jul 1, 2024

I tried to fix this in #30317 but could not get a review before automation closed it. Trying again in #30716.

isker added a commit to isker/aws-cdk that referenced this issue Jul 1, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
c0eeb83 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
isker added a commit to isker/aws-cdk that referenced this issue Jul 6, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
a1b6bb5 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
isker added a commit to isker/aws-cdk that referenced this issue Jul 31, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
45c943b 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
isker added a commit to isker/aws-cdk that referenced this issue Jul 31, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
dc030fd 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
isker added a commit to isker/aws-cdk that referenced this issue Jul 31, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
5899b6b 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
isker added a commit to isker/aws-cdk that referenced this issue Aug 1, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
7773043 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
isker added a commit to isker/aws-cdk that referenced this issue Aug 1, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
8cd144f 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
isker added a commit to isker/aws-cdk that referenced this issue Aug 1, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
49b2b42 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
isker added a commit to isker/aws-cdk that referenced this issue Aug 1, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
05531b1 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
isker added a commit to isker/aws-cdk that referenced this issue Aug 29, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
6883cc6 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
isker added a commit to isker/aws-cdk that referenced this issue Aug 29, 2024
@isker
feat(ec2): support throughput on LaunchTemplate EBS volumes
b0ad7d0 
This support was simply not included in ec2 when it was added to
autoscaling in aws#22441. I have copied that PR's implementation
implementation to ec2 and similarly adapted its tests.

Fixes aws#24341.
@mergify mergify bot closed this as completed in #30716 Aug 29, 2024
@mergify mergify bot closed this as completed in 6ed0bed Aug 29, 2024
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
xazhao pushed a commit to xazhao/aws-cdk that referenced this issue Sep 12, 2024
@isker @xazhao
feat(ec2): support throughput on LaunchTemplate EBS volumes (aws#30716)
f8221f9 
### Issue # (if applicable)

Fixes aws#24341.

### Reason for this change

You currently can't specify `throughput` on LaunchTemplate EBS volumes.

### Description of changes

This support was simply not included in ec2 when it was added to autoscaling in aws#22441. I have copied that PR's implementation implementation to ec2 and similarly adapted its tests.

### Description of how you validated changes

Unit and integration tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
3 participants
@pahud @isker @adrabkin